Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: if conn.Stat returns no file Delete is successful #186

Merged
merged 1 commit into from
Feb 1, 2024
Merged

fix: if conn.Stat returns no file Delete is successful #186

merged 1 commit into from
Feb 1, 2024

Conversation

adamdecaf
Copy link
Member

We can check this earlier from conn.Stat which returns the standard Go errors.

@adamdecaf adamdecaf requested a review from atonks2 as a code owner February 1, 2024 15:54
adamdecaf added a commit to moov-io/go-ftp that referenced this pull request Feb 1, 2024
@adamdecaf
test: verify deleting missing files isn't an error
a65f595 
See: moov-io/go-sftp#186
@adamdecaf adamdecaf merged commit d6ff9ab into master Feb 1, 2024
3 checks passed
@adamdecaf adamdecaf deleted the early-check-deleted-file branch February 1, 2024 16:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alovak alovak alovak approved these changes

@atonks2 atonks2 Awaiting requested review from atonks2 atonks2 is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@adamdecaf @alovak