Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

api: expose file.isIncoming as a query param #355

Closed
wants to merge 1 commit into from

Conversation

atonks2
Copy link
Contributor

@atonks2 atonks2 commented Nov 21, 2023

The file.isIncoming flag wasn't being honored consistently between files created via JSON or file upload. Additionally, writing an incoming file without SenderSupplied would fail because the writer wasn't checking isIncoming.

This change makes it possible to explicitly specify isIncoming on file creation via query param, and honors the flag in all subsequent requests (get file, get file contents, etc.).

@atonks2 atonks2 requested a review from adamdecaf as a code owner November 21, 2023 20:24
@codecov-commenter
Copy link

Codecov Report

Merging #355 (356139d) into master (71d51ac) will decrease coverage by 0.02%.
The diff coverage is 72.72%.

❗ Current head 356139d differs from pull request most recent head 8654fe9. Consider uploading reports for the commit 8654fe9 to get more accurate results

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #355      +/-   ##
==========================================
- Coverage   74.85%   74.84%   -0.02%     
==========================================
  Files          73       73              
  Lines        8653     8657       +4     
==========================================
+ Hits         6477     6479       +2     
- Misses       1609     1611       +2     
  Partials      567      567              

@atonks2 atonks2 closed this Nov 28, 2023
@atonks2 atonks2 deleted the expose-incoming-file-query-param branch November 28, 2023 16:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants