Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

only validate FI IdentificationCode when present or required #365

Merged
merged 1 commit into from
Feb 1, 2024

Conversation

atonks2
Copy link
Contributor

@atonks2 atonks2 commented Feb 1, 2024

What does this pull request do?
This PR fixes a bug where the value of FinancialInstitution.IdentificationCode was being validated when it was actually supposed to be empty.

What Wire specification are you referencing?
Fedwire Application Interface Manual (FAIM) Version 3.0.4

@atonks2 atonks2 requested a review from adamdecaf as a code owner February 1, 2024 01:07
@codecov-commenter
Copy link

Codecov Report

Merging #365 (0952e78) into master (ebf16d9) will increase coverage by 0.04%.
The diff coverage is 100.00%.

❗ Current head 0952e78 differs from pull request most recent head 3421101. Consider uploading reports for the commit 3421101 to get more accurate results

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #365      +/-   ##
==========================================
+ Coverage   74.82%   74.86%   +0.04%     
==========================================
  Files          73       73              
  Lines        8684     8682       -2     
==========================================
+ Hits         6498     6500       +2     
+ Misses       1619     1615       -4     
  Partials      567      567              

@wadearnold
Copy link
Member

Thank you!

@atonks2 atonks2 merged commit fc2a056 into master Feb 1, 2024
6 checks passed
@atonks2 atonks2 deleted the fix-financial-institution-validation branch February 1, 2024 16:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants