Fix: Stop making assumption that bundle might start with 'define(' (#31)

morriq · Dec 18, 2019 · d75acb5 · d75acb5
1 parent f0ad978
commit d75acb5
Showing 1 changed file with 3 additions and 6 deletions.
diff --git a/lib/index.js b/lib/index.js
@@ -49,18 +49,15 @@ class MicroservicesWebpackPlugin {
 	async tapAsync(compilation, callback) {
     this.modules = await this.createUrlsToModules(this.modules);
 
+    const { libraryTarget } = compilation.runtimeTemplate.outputOptions;
+
 		compilation.assets = fromEntries(Object.entries(compilation.assets)
       .map(([fileName, asset]) => {
-        if (!fileName.includes('.js')) {
+        if (!fileName.includes('.js') || libraryTarget !== 'amd') {
           return [fileName, asset];
         }
 
         const source = asset.source();
-        const supportAmdOnly = 'define(';
-
-        if (!source.startsWith(supportAmdOnly)) {
-          return [fileName, asset];
-        }
 
         const value = [
           this.modules