Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat!: lit 3 update, migrate to vitest with browser mode #220

Merged
merged 36 commits into from
Jan 10, 2024
Merged

Conversation

motss
Copy link
Owner

@motss motss commented Dec 8, 2023

Changes

  1. Migrate to vitest with experimental browser mode
    1. Skip some tests that require keyboard events and .dispatchEvent(new KeyboardEvent()) does not work for those tests especially tab to focus, hence causing the code coverage in Codecov to drop below 100%.
  2. Replace npm with pnpm
  3. Update dependencies to lit@3

Signed-off-by: Rong Sen Ng (motss) <[email protected]>
@motss motss self-assigned this Dec 8, 2023
@motss motss changed the title feat: migrate to vitest + browser mode feat!: migrate to vitest + browser mode Dec 8, 2023
Signed-off-by: Rong Sen Ng (motss) <[email protected]>
Signed-off-by: Rong Sen Ng (motss) <[email protected]>
Signed-off-by: Rong Sen Ng (motss) <[email protected]>
Copy link

codecov bot commented Dec 27, 2023

Codecov Report

Attention: 31 lines in your changes are missing coverage. Please review.

Comparison is base (3582b2c) 100.00% compared to head (6a0d6d6) 92.82%.
Report is 7 commits behind head on main.

Files Patch % Lines
src/date-picker-input/date-picker-input.ts 82.50% 7 Missing and 7 partials ⚠️
src/year-grid/year-grid.ts 57.14% 9 Missing and 3 partials ⚠️
src/month-calendar/month-calendar.ts 90.00% 1 Missing and 3 partials ⚠️
src/date-picker/date-picker.ts 98.78% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##              main     #220      +/-   ##
===========================================
- Coverage   100.00%   92.82%   -7.18%     
===========================================
  Files           58       58              
  Lines         3305      711    -2594     
  Branches       238      155      -83     
===========================================
- Hits          3305      660    -2645     
- Misses           0       32      +32     
- Partials         0       19      +19     
Flag Coverage Δ
unit_tests 92.82% <88.92%> (-7.18%) ⬇️
unit_tests_helpers ?

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

motss added 19 commits January 5, 2024 02:21
Signed-off-by: Rong Sen Ng (motss) <[email protected]>
Signed-off-by: Rong Sen Ng (motss) <[email protected]>
fix: fix .toMatchInlineSnapshot throws uncaught error

Signed-off-by: Rong Sen Ng (motss) <[email protected]>
Signed-off-by: Rong Sen Ng (motss) <[email protected]>
Signed-off-by: Rong Sen Ng (motss) <[email protected]>
Signed-off-by: Rong Sen Ng (motss) <[email protected]>
Signed-off-by: Rong Sen Ng (motss) <[email protected]>
Signed-off-by: Rong Sen Ng (motss) <[email protected]>
Signed-off-by: Rong Sen Ng (motss) <[email protected]>
@motss motss marked this pull request as ready for review January 10, 2024 08:30
@motss motss changed the title feat!: migrate to vitest + browser mode feat!: lit 3 update, migrate to vitest with browser mode Jan 10, 2024
@motss motss merged commit 3471d72 into main Jan 10, 2024
4 of 6 checks passed
@motss motss deleted the feat/vitest branch January 10, 2024 08:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant