Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(#142): update normalizeSync input type to string only #143

Merged
merged 2 commits into from
Mar 24, 2024

Conversation

harveysanders
Copy link
Contributor

Description

Fix #142

Changes

  • Make input parameter for normalizeSync, normalize required, string only
  • Update README
  • Update test

Testings


> [email protected] test
> vitest --coverage


 DEV  v0.25.7 /Users/opsparkowl/Documents/side_projects/normalize-diacritics
      Coverage enabled with c8

 ✓ src/tests/error.test.ts (2)
 ✓ src/tests/normalize-sync.test.ts (14)
 ✓ src/tests/normalize.test.ts (14)

 Test Files  3 passed (3)
      Tests  30 passed (30)
   Start at  15:51:55
   Duration  955ms (transform 406ms, setup 0ms, collect 175ms, tests 38ms)

 % Coverage report from c8
-------------------|---------|----------|---------|---------|-------------------
File               | % Stmts | % Branch | % Funcs | % Lines | Uncovered Line #s
-------------------|---------|----------|---------|---------|-------------------
All files          |     100 |      100 |     100 |     100 |
 diacritics.ts     |     100 |      100 |     100 |     100 |
 index.ts          |     100 |      100 |     100 |     100 |
 normalize-sync.ts |     100 |      100 |     100 |     100 |
 normalize.ts      |     100 |      100 |     100 |     100 |
 types.ts          |     100 |      100 |     100 |     100 |
-------------------|---------|----------|---------|---------|-------------------

@harveysanders harveysanders requested a review from motss as a code owner March 22, 2024 19:54
Copy link

socket-security bot commented Mar 22, 2024

New and removed dependencies detected. Learn more about Socket for GitHub ↗︎

Package New capabilities Transitives Size Publisher
npm/[email protected] None 0 32.4 MB typescript-bot

🚮 Removed packages: npm/[email protected]

View full report↗︎

README.md Outdated Show resolved Hide resolved
Co-authored-by: The web walker <[email protected]>
Signed-off-by: Harvey Sanders <[email protected]>
@harveysanders
Copy link
Contributor Author

@motss Thanks for the review. I've made the requested changes

Copy link
Owner

@motss motss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 LGTM!

@harveysanders Thanks for your contribution.

Copy link

codecov bot commented Mar 24, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 100.00%. Comparing base (5f96d66) to head (dcd2469).
Report is 13 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff            @@
##              main      #143   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files            5         5           
  Lines          152       151    -1     
  Branches         5         5           
=========================================
- Hits           152       151    -1     
Flag Coverage Δ
unit_tests 100.00% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@motss motss enabled auto-merge (squash) March 24, 2024 08:08
@motss motss disabled auto-merge March 24, 2024 08:12
@motss motss merged commit 4376983 into motss:main Mar 24, 2024
11 checks passed
@harveysanders harveysanders deleted the normalizeSync-input-type branch March 24, 2024 13:18
@harveysanders
Copy link
Contributor Author

@motss do you have an estimate when these changes will go into another release?

Thanks 🙂

@motss
Copy link
Owner

motss commented Apr 14, 2024

@harveysanders Apologies to the delay. The fix has been released in v5.0.0.

@harveysanders
Copy link
Contributor Author

@motss No problem. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Consider limiting input type to string
2 participants