-
-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(#142): update normalizeSync input type to string only #143
Conversation
New and removed dependencies detected. Learn more about Socket for GitHub ↗︎
🚮 Removed packages: npm/[email protected] |
Co-authored-by: The web walker <[email protected]> Signed-off-by: Harvey Sanders <[email protected]>
@motss Thanks for the review. I've made the requested changes |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍 LGTM!
@harveysanders Thanks for your contribution.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #143 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 5 5
Lines 152 151 -1
Branches 5 5
=========================================
- Hits 152 151 -1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
@motss do you have an estimate when these changes will go into another release? Thanks 🙂 |
@harveysanders Apologies to the delay. The fix has been released in v5.0.0. |
@motss No problem. Thanks! |
Description
Fix #142
Changes
input
parameter fornormalizeSync
,normalize
required,string
onlyTestings