Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add flag to enforce mTLS #148

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

S-Bohn
Copy link

@S-Bohn S-Bohn commented Feb 22, 2022

Adds dedicated mTLS enabled endpoint, see: #147

@S-Bohn S-Bohn requested a review from moul as a code owner February 22, 2022 15:52
@auto-add-label auto-add-label bot added the WIP label Feb 22, 2022
@trafico-bot trafico-bot bot added the 🚧 WIP Still work-in-progress, please don't review and don't merge label Feb 22, 2022
@codecov
Copy link

codecov bot commented Feb 22, 2022

Codecov Report

Merging #148 (368aa04) into master (90bb2f8) will not change coverage.
The diff coverage is n/a.

❗ Current head 368aa04 differs from pull request most recent head 30b248c. Consider uploading reports for the commit 30b248c to get more accurate results

@@           Coverage Diff           @@
##           master     #148   +/-   ##
=======================================
  Coverage   37.14%   37.14%           
=======================================
  Files           1        1           
  Lines          70       70           
=======================================
  Hits           26       26           
  Misses         44       44           
Flag Coverage Δ
unittests 37.14% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@S-Bohn S-Bohn force-pushed the dev/sbohn/add-mtls-auth branch from 368aa04 to 30b248c Compare September 6, 2022 12:18
@S-Bohn
Copy link
Author

S-Bohn commented Sep 6, 2022

Hey @moul – sorry for the long delay.

I updated that PR with a more straightforward solution. I just added a new flag that enforces client-cert authentication. This solves my issue writing the e2e test and probably has less impact.

@S-Bohn S-Bohn changed the title WIP: add mTLS Add flag to enforce mTLS Sep 6, 2022
@trafico-bot trafico-bot bot added 🔍 Ready for Review Pull Request is not reviewed yet and removed 🚧 WIP Still work-in-progress, please don't review and don't merge labels Sep 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🔍 Ready for Review Pull Request is not reviewed yet WIP
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant