Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removed self referencing absolute imports [libs/movex-react] #53

Merged
merged 1 commit into from
Oct 8, 2023

Conversation

ikunal-04
Copy link
Contributor

Fixes #38
Hey @GabrielCTroia I'm requesting to review my changes. Please let me know if you have any feedback.

@GabrielCTroia
Copy link
Contributor

GabrielCTroia commented Oct 7, 2023

Hey @ikunal-04! Thank you for your changes - it looks good and I'm about to merge! 🎉

One last step before I can, can you please sign your commit? Check this if you have issues https://docs.github.com/en/authentication/managing-commit-signature-verification/about-commit-signature-verification

@GabrielCTroia GabrielCTroia added good first issue Good for newcomers hacktoberfest Improvements that qualify for Hacktoberfest labels Oct 7, 2023
@ikunal-04
Copy link
Contributor Author

ikunal-04 commented Oct 8, 2023

Hey @GabrielCTroia by reading this docs I'm able to sign and verify my commit locally, now I'm only having issues to push my locally signed commit to the github?
Or should I make a new pull request?

@GabrielCTroia
Copy link
Contributor

You can force push like git push -f

@ikunal-04
Copy link
Contributor Author

It worked @GabrielCTroia. Now my commit is signed! 😊👍

@ikunal-04
Copy link
Contributor Author

Hey @GabrielCTroia I'm assuming that my PR is good to merge but still if there is any feedback, please let me know! 😊

@GabrielCTroia GabrielCTroia merged commit 9998dcb into movesthatmatter:main Oct 8, 2023
2 checks passed
@GabrielCTroia
Copy link
Contributor

Hey @GabrielCTroia I'm assuming that my PR is good to merge but still if there is any feedback, please let me know! 😊

Yep, merged it! Thank you for your contribution! 🙌

One last thing, could you please give us a star so we can bump the repo up! ❤️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers hacktoberfest Improvements that qualify for Hacktoberfest
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[libs/movex-react] Remove self referencing absolute imports
2 participants