Improve Portability #1
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
||
| /* HP/UX 9 (%@#!) writes to sscanf strings */ | ||
| tmp_version = strdup("$min_log4cpp_version"); | ||
| if (sscanf(tmp_version, "%d.%d.%d", &major, &minor, µ) != 3) { |
There was a problem hiding this comment.
this will fail for log4cpp version 1.0 which returns this:
# /usr/bin/log4cpp-config --version
1.0
There was a problem hiding this comment.
Have you actually tested it or are you guessing? The output of log4cpp-config is fed through sed to add a ".0" to the end if the version is only two digits (line 41). Does that fail for you? (Works for me both with BSD sed and GNU sed.)
There was a problem hiding this comment.
sorry yes it works fine
I did test but made a mistake.
|
I've split the master branch into several orthogonal topic branches to facilitate merging of the non-problematic parts. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some more improvements to BSD support and general portability:
Tested on FreeBSD 8.2, OpenBSD 4.8, Linux.
Fixes issue #2.