Add AppSplashController to tests (#1127)

mozilla-mobile · Jul 18, 2018 · 4abaa41 · 4abaa41
1 parent f14794c
commit 4abaa41
Showing 1 changed file with 11 additions and 6 deletions.
diff --git a/ClientTests/BrowserViewControllerTests.swift b/ClientTests/BrowserViewControllerTests.swift
@@ -14,8 +14,13 @@ import XCTest
 class BrowserViewControllerTests: XCTestCase {
     private let mockUserDefaults = MockUserDefaults()
 
+    class TestAppSplashController: AppSplashController {
+        var splashView = UIView()
+        func toggleSplashView(hide: Bool) {}
+    }
+
     func testRequestReviewThreshold() {
-        let bvc = BrowserViewController()
+        let bvc = BrowserViewController(appSplashController: TestAppSplashController())
         mockUserDefaults.clear()
 
         // Ensure initial threshold is set
@@ -50,7 +55,7 @@ class BrowserViewControllerTests: XCTestCase {
     }
 
     func testShareButtonPreviouslyInGroup() {
-        let bvc = BrowserViewController()
+        let bvc = BrowserViewController(appSplashController: TestAppSplashController())
         mockUserDefaults.clear()
         mockUserDefaults.set(10, forKey: BrowserViewController.userDefaultsTrackersBlockedKey)
         mockUserDefaults.set(true, forKey: BrowserViewController.userDefaultsShareTrackerStatsKeyOLD)
@@ -61,7 +66,7 @@ class BrowserViewControllerTests: XCTestCase {
     }
 
     func testShareButtonPreviouslyOutGroup() {
-        let bvc = BrowserViewController()
+        let bvc = BrowserViewController(appSplashController: TestAppSplashController())
         mockUserDefaults.clear()
         mockUserDefaults.set(10, forKey: BrowserViewController.userDefaultsTrackersBlockedKey)
         mockUserDefaults.set(false, forKey: BrowserViewController.userDefaultsShareTrackerStatsKeyOLD)
@@ -71,7 +76,7 @@ class BrowserViewControllerTests: XCTestCase {
     }
 
     func testShareButtonHasNotHitEnoughTrackers() {
-        let bvc = BrowserViewController()
+        let bvc = BrowserViewController(appSplashController: TestAppSplashController())
         mockUserDefaults.clear()
         mockUserDefaults.set(9, forKey: BrowserViewController.userDefaultsTrackersBlockedKey)
 
@@ -80,7 +85,7 @@ class BrowserViewControllerTests: XCTestCase {
     }
 
     func testShareButtonInGroup() {
-        let bvc = BrowserViewController()
+        let bvc = BrowserViewController(appSplashController: TestAppSplashController())
         mockUserDefaults.clear()
         mockUserDefaults.set(10, forKey: BrowserViewController.userDefaultsTrackersBlockedKey)
         mockUserDefaults.set(true, forKey: BrowserViewController.userDefaultsShareTrackerStatsKeyNEW)
@@ -90,7 +95,7 @@ class BrowserViewControllerTests: XCTestCase {
     }
 
     func testShareButtonOutGroup() {
-        let bvc = BrowserViewController()
+        let bvc = BrowserViewController(appSplashController: TestAppSplashController())
         mockUserDefaults.clear()
         mockUserDefaults.set(10, forKey: BrowserViewController.userDefaultsTrackersBlockedKey)
         mockUserDefaults.set(false, forKey: BrowserViewController.userDefaultsShareTrackerStatsKeyNEW)