Remove unnecessary synchronize() call. (#1613)

Blockzilla/UserAgent.swift

@@ -99,7 +99,6 @@ class UserAgent {
 
     private func setUserAgent(userAgent: String) {
         userDefaults.register(defaults: ["UserAgent": userAgent])
-        userDefaults.synchronize()
     }
 
     public func changeUserAgent() {

ClientTests/UserAgentTests.swift

@@ -28,7 +28,6 @@ class UserAgentTests: XCTestCase {
         mockUserDefaults.set(fakeUserAgent, forKey: "UserAgent")
 
         _ = UserAgent(userDefaults: mockUserDefaults)
-        XCTAssertTrue(mockUserDefaults.synchronizeCalled)
         XCTAssertNotNil(mockUserDefaults.registerValue)
         XCTAssertEqual(mockUserDefaults.registerValue!["UserAgent"] as? String, fakeUserAgent)
     }
@@ -40,7 +39,6 @@ class UserAgentTests: XCTestCase {
         mockUserDefaults.removeObject(forKey: "UserAgent")
 
         _ = UserAgent(userDefaults: mockUserDefaults)
-        XCTAssertTrue(mockUserDefaults.synchronizeCalled)
         XCTAssertNotNil(mockUserDefaults.registerValue)
         XCTAssertNotNil(mockUserDefaults.string(forKey: "LastFocusVersionNumber"))
         XCTAssertTrue(((mockUserDefaults.registerValue!["UserAgent"] as? String)?.contains("FxiOS"))!)
@@ -52,23 +50,16 @@ class UserAgentTests: XCTestCase {
 }
 
 fileprivate class MockUserDefaults: UserDefaults {
-    var synchronizeCalled = false
     var registerValue: [String : Any]?
 
     func clear() {
         removeObject(forKey: "LastFocusVersionNumber")
         removeObject(forKey: "LastFocusBuildNumber")
         removeObject(forKey: "LastDeviceSystemVersionNumber")
         removeObject(forKey: "UserAgent")
-        synchronizeCalled = false
         registerValue = nil
     }
 
-    override func synchronize() -> Bool {
-        synchronizeCalled = true
-        return true
-    }
-
     override func register(defaults registrationDictionary: [String : Any]) {
         registerValue = registrationDictionary
     }

SentryIntegration.swift

@@ -44,7 +44,6 @@ public class SentryIntegration {
             // be used for both the main application and the app extensions.
             if let defaults = UserDefaults(suiteName: AppInfo.sharedContainerIdentifier), defaults.string(forKey: SentryDeviceAppHashKey) == nil {
                 defaults.set(Bytes.generateRandomBytes(DeviceAppHashLength).hexEncodedString, forKey: SentryDeviceAppHashKey)
-                defaults.synchronize()
             }
 
             // For all outgoing reports, override the default device identifier with our own random

Shared/Settings.swift

@@ -52,12 +52,10 @@ struct Settings {
 
     static func setCustomDomainSetting(domains: [String]) {
         prefs.set(domains, forKey: customDomainSettingKey)
-        prefs.synchronize()
     }
 
     static func set(_ value: Bool, forToggle toggle: SettingsToggle) {
         prefs.set(value, forKey: toggle.rawValue)
-        prefs.synchronize()
     }
 
     static func siriRequestsErase() -> Bool {
@@ -66,6 +64,5 @@ struct Settings {
 
     static func setSiriRequestErase(to value: Bool) {
         prefs.set(value, forKey: siriRequestsEraseKey)
-        prefs.synchronize()
     }
 }