Frontend Compatibility for Multiple Promoted Addon Groups #13343
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #13343 +/- ##
=======================================
Coverage 98.28% 98.28%
=======================================
Files 267 267
Lines 10620 10628 +8
Branches 3237 3241 +4
=======================================
+ Hits 10438 10446 +8
Misses 169 169
Partials 13 13 ☔ View full report in Codecov by Sentry. |
chrstinalin
requested review from
a team and
KevinMind
and removed request for
a team
chrstinalin
force-pushed
the
#14986-partner-addons-frontend
branch
from
b99585a to
f7c66f9
Compare
There was a problem hiding this comment.
That's a good start, thanks. I provided some diffs to help you get to where I'd like us to go.
Additionally, I noticed a bunch of UI glitches:
-
For instance, how should we treat themes?
-
Badges in the search results should have some padding in between:
-
Multiple badges in the "more add-ons by this developer" card look a bit off:
-
same for "more themes by artist":
-
and in the user profile:
-
and in the "other popular add-ons" card:
KevinMind
requested review from
KevinMind and
willdurand
and removed request for
KevinMind
|
@willdurand idk what is happening but github refuses to let me remove myself, in the process of wrestling the UI I re-requested review from you (accidentally) |
chrstinalin
dismissed
willdurand’s stale review
updated implementation to only show one badge in all scenarios
Closes mozilla/addons#15226
Makes the frontend compatible with receiving a list of promoted addons rather than just one, per mozilla/addons-server#22888.
Chooses to display only the most 'important' badge.
Still allows for just one promoted addon (i.e won't break anything while mozilla/addons-server#22888 is in progress)