Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Handle JSONLD arrays (fixes #908) #947

Merged
merged 2 commits into from
Jan 16, 2025
Merged

Handle JSONLD arrays (fixes #908) #947

merged 2 commits into from
Jan 16, 2025

Conversation

ysuhaas
Copy link
Contributor

@ysuhaas ysuhaas commented Jan 10, 2025 •
edited
Loading

This code change:

  • Adds handling for the case where the <script type="application/ld+json"> element contains an array of objects to correctly parse the metadata from the first available node

Fixes #908

gijsk
gijsk approved these changes Jan 16, 2025
View reviewed changes
Copy link
Contributor

@gijsk gijsk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense, thank you, also for the test!

@gijsk gijsk merged commit 118f015 into mozilla:main Jan 16, 2025
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gijsk gijsk gijsk approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

if JSONLD is array of objects, its metadata are not processed
2 participants
@ysuhaas @gijsk