Use "testqueue" for unit tests #1603
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I noticed that when I run basket locally, it often had tasks being retried from the test runs. The retried tasks were being left scheduled in Redis after a test run, so running basket would retry them.
This updates the default queue in tests to use a separate queue. Apparently the
queue.empty()only clears the active queue, not theScheduledJobRegistry. It looks to be a bit of a pain to remove scheduled jobs, but not impossible. I can add this at some future time.Regardless, it's probably a better idea to use a separate queue for testing just like we have a separate db for testing.