refactor: remove fdir from benchmark

mrmlnc · Dec 1, 2024 · 5f42092 · 5f42092
1 parent 6e15541
commit 5f42092
Show file tree

Hide file tree

Showing 7 changed files with 5 additions and 48 deletions.
diff --git a/herebyfile.mjs b/herebyfile.mjs
@@ -73,9 +73,9 @@ export const {
 	productStreamTask,
 	productSyncTask,
 } = {
-	productAsyncTask: makeBenchSuiteTask('product', 'async', PRODUCT_ASYNC_SUITE, ['fast-glob', 'node-glob', 'fdir', 'tinyglobby']),
+	productAsyncTask: makeBenchSuiteTask('product', 'async', PRODUCT_ASYNC_SUITE, ['fast-glob', 'node-glob', 'tinyglobby']),
 	productStreamTask: makeBenchSuiteTask('product', 'stream', PRODUCT_STREAM_SUITE, ['fast-glob', 'node-glob']),
-	productSyncTask: makeBenchSuiteTask('product', 'sync', PRODUCT_SYNC_SUITE, ['fast-glob', 'node-glob', 'fdir', 'tinyglobby']),
+	productSyncTask: makeBenchSuiteTask('product', 'sync', PRODUCT_SYNC_SUITE, ['fast-glob', 'node-glob', 'tinyglobby']),
 };
 
 export const {

diff --git a/package.json b/package.json
@@ -40,7 +40,6 @@
     "eslint-config-mrmlnc": "^5.0.0",
     "execa": "^7.2.0",
     "fast-glob": "^3.3.2",
-    "fdir": "^6.4.2",
     "glob": "^11.0.0",
     "hereby": "^1.10.0",
     "mocha": "^10.8.2",

diff --git a/src/benchmark/suites/product/async.ts b/src/benchmark/suites/product/async.ts
@@ -4,7 +4,7 @@ import * as bencho from 'bencho';
 
 import * as utils from '../../utils';
 
-type GlobImplementation = 'fast-glob' | 'fdir' | 'node-glob' | 'tinyglobby';
+type GlobImplementation = 'fast-glob' | 'node-glob' | 'tinyglobby';
 // eslint-disable-next-line @typescript-eslint/no-explicit-any
 type GlobImplFunction = (...args: any[]) => Promise<unknown[]>;
 
@@ -36,19 +36,6 @@ class Glob {
 		}));
 	}
 
-	public async measureFdir(): Promise<void> {
-		const { fdir: FdirBuilder } = await utils.importAndMeasure(utils.importFdir);
-
-		const fdir = new FdirBuilder()
-			.withBasePath()
-			.withRelativePaths()
-			// Other solutions do not include hidden files by default
-			.globWithOptions([this.#pattern], { dot: false })
-			.crawl(this.#cwd);
-
-		await this.#measure(() => fdir.withPromise());
-	}
-
 	public async measureTinyGlobby(): Promise<void> {
 		const tinyglobby = await utils.importAndMeasure(utils.importTinyGlobby);
 
@@ -94,11 +81,6 @@ class Glob {
 			break;
 		}
 
-		case 'fdir': {
-			await glob.measureFdir();
-			break;
-		}
-
 		case 'tinyglobby': {
 			await glob.measureTinyGlobby();
 			break;

diff --git a/src/benchmark/suites/product/sync.ts b/src/benchmark/suites/product/sync.ts
@@ -4,7 +4,7 @@ import * as bencho from 'bencho';
 
 import * as utils from '../../utils';
 
-type GlobImplementation = 'fast-glob' | 'fdir' | 'node-glob' | 'tinyglobby';
+type GlobImplementation = 'fast-glob' | 'node-glob' | 'tinyglobby';
 // eslint-disable-next-line @typescript-eslint/no-explicit-any
 type GlobImplFunction = (...args: any[]) => unknown[];
 
@@ -36,19 +36,6 @@ class Glob {
 		}));
 	}
 
-	public async measureFdir(): Promise<void> {
-		const { fdir: FdirBuilder } = await utils.importAndMeasure(utils.importFdir);
-
-		const fdir = new FdirBuilder()
-			.withBasePath()
-			.withRelativePaths()
-			// Other solutions do not include hidden files by default
-			.globWithOptions([this.#pattern], { dot: false })
-			.crawl(this.#cwd);
-
-		this.#measure(() => fdir.sync());
-	}
-
 	public async measureTinyGlobby(): Promise<void> {
 		const tinyglobby = await utils.importAndMeasure(utils.importTinyGlobby);
 
@@ -94,11 +81,6 @@ class Glob {
 			break;
 		}
 
-		case 'fdir': {
-			await glob.measureFdir();
-			break;
-		}
-
 		case 'tinyglobby': {
 			await glob.measureTinyGlobby();
 			break;

diff --git a/src/benchmark/utils.ts b/src/benchmark/utils.ts
@@ -5,7 +5,6 @@ import * as bencho from 'bencho';
 import type * as currentVersion from '..';
 import type * as previousVersion from 'fast-glob';
 import type * as glob from 'glob';
-import type * as fdir from 'fdir';
 import type * as tg from 'tinyglobby';
 
 export function timeStart(): number {
@@ -32,10 +31,6 @@ export function importNodeGlob(): Promise<typeof glob> {
 	return import('glob');
 }
 
-export function importFdir(): Promise<typeof fdir> {
-	return import('fdir');
-}
-
 export function importTinyGlobby(): Promise<typeof tg> {
 	return import('tinyglobby');
 }

diff --git a/src/tests/e2e/runner.ts b/src/tests/e2e/runner.ts
@@ -1,7 +1,7 @@
 /* eslint-disable mocha/no-setup-in-describe */
 import * as assert from 'node:assert';
 
-import snapshotIt from 'snap-shot-it';
+import * as snapshotIt from 'snap-shot-it';
 import { describe, it } from 'mocha';
 
 import * as fg from '../..';

diff --git a/tsconfig.json b/tsconfig.json
@@ -21,7 +21,6 @@
 
 		"forceConsistentCasingInFileNames": true,
 		"verbatimModuleSyntax": false,
-		"esModuleInterop": true,
 
 		"downlevelIteration": true,
 		"declaration": true,