Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mount cgroups #22

Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open

Mount cgroups #22

wants to merge 4 commits into from

Conversation

mrunalp
Copy link
Owner

@mrunalp mrunalp commented Dec 4, 2015

@rhatdan I got the basics working. Please take a look.

Still to do

  • Make cgroups read only
  • Add configure option
  • Cleanup

Signed-off-by: Mrunal Patel <[email protected]>
Signed-off-by: Mrunal Patel <[email protected]>
@mrunalp
Copy link
Owner Author

mrunalp commented Dec 5, 2015

I have run into a race with this. What happens is that we mount cgroups with the correct options and labels but then libcontainer comes along everything under /sys gets relabeled to system_u:object_r:sysfs_t:s0. As a side effect of this, I see the cgroup mount but no directory contents. Not sure if we can fix this :(

@mrunalp
Copy link
Owner Author

mrunalp commented Dec 5, 2015

One option is to propose pre/post mount hooks in the spec.

@rhatdan
Copy link
Contributor

rhatdan commented Dec 7, 2015

It changes the labels on the /sys/fs/cgroup content?

@mrunalp
Copy link
Owner Author

mrunalp commented Dec 7, 2015

@rhatdan Yes. Is this something we can control in the labeling?

@rhatdan
Copy link
Contributor

rhatdan commented Dec 8, 2015

My point was, does the /sys/fs/cgroup label change?

@mrunalp
Copy link
Owner Author

mrunalp commented Dec 8, 2015

Yes, the label changes.


t = mnt_new_table();
if (!t)
return -1;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Need error message

mrunalp pushed a commit that referenced this pull request Sep 23, 2016
Fix order of mounts under /run
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants