Reorder msgpack_packer struct #373
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Reduce its size from 224 to 216B.
Comment on lines
+39
to
44
| bool compatibility_mode; | ||
| bool has_bigint_ext_type; | ||
| bool has_symbol_ext_type; | ||
|
|
||
| /* options */ | ||
| bool comaptibility_mode; |
There was a problem hiding this comment.
Btw, if you use a bitfield, you can even turn this from 16B down to 8B
There was a problem hiding this comment.
I'm never too sure how bitfields impact performance. Probably negligible, but I only made this change because it was an obvious small waste.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reduce its size from 224 to 216B.