Configurable serial #1
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Many of the defaults don't work with some signs, so pass through pretty much all of the options for serial.Serial through the serial interface constructor, while still retaining backwards compatibility and late port initialisation in connect()
|
|
||
| from alphasign.interfaces import base | ||
|
|
||
|
|
|
Thanks for the pull request. I've made some nit comments. I'll merge when they are addressed. |
|
Please also see the problem mentioned in #3 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi there,
I've got an older sign I'm talking to over RS232. The default settings weren't working, so here are a couple of changes so that they are easy to configure at creation time, without breaking existing behaviour.
Cheers,
David