-
-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[core] Improve React 19 support #15769
Changes from 86 commits
93bf5ac
1506c31
c656122
91daf42
914270e
4dc9d67
c62046e
a4e6a2f
e7dc07d
85998ce
ddbae8e
4ca779b
8c09a3e
f652cd8
190e37d
be7cbc8
05c307b
ecd1f5a
4b6da95
81c09f3
9ab8ac7
f3e6970
731f5dc
ea994c8
a6362d3
8317602
aad5677
41ab3c2
dede7d1
5ef32f2
3bb3494
443e8fa
b825c72
18f2912
37678a0
f8d425b
6afea09
09ce052
c243a43
e0f937c
d53daa4
2850c26
bf1ea94
04632a8
0f41ede
2662a65
d437bc1
fae1f8d
80fd09f
87c2d9e
6c89540
331478a
61f7fa4
94027c4
f8e48f5
6b4a212
a3b032c
3974d69
39f276c
35506cc
f577a75
e6ef9e4
3d43e6a
52ffe7b
e14cbc3
2e4bd1a
08f84bf
7220a0b
6e1070f
a5c40a3
3bf257c
efebb48
9d56411
caf3bd8
3e8e486
cdc72a2
1475f33
a4c728e
ca32e1b
dd14eba
8c71c2d
46314cd
1ce6f75
ed403a3
3d40915
bb0868f
94976e5
78a4dea
4d740b7
85bf3f5
7187ad0
636a349
4fa033c
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -90,13 +90,13 @@ | |
"@emotion/cache": "^11.14.0", | ||
"@emotion/react": "^11.14.0", | ||
"@emotion/styled": "^11.14.0", | ||
"@mui/icons-material": "^5.16.11", | ||
"@mui/icons-material": "^5.16.13", | ||
"@mui/internal-babel-plugin-resolve-imports": "1.0.19", | ||
"@mui/internal-markdown": "^1.0.22", | ||
"@mui/internal-test-utils": "^1.0.23", | ||
"@mui/material": "^5.16.11", | ||
"@mui/monorepo": "github:mui/material-ui#0ea1ef5241dae88c1f0ca093a4ff4f02a267fa60", | ||
"@mui/utils": "^5.16.8", | ||
"@mui/material": "^5.16.13", | ||
"@mui/monorepo": "github:mui/material-ui#356d5dffbcbc1c18b5ab8060a173ea7a3e90b58c", | ||
"@mui/utils": "^5.16.13", | ||
"@next/eslint-plugin-next": "15.1.2", | ||
"@octokit/plugin-retry": "^7.1.2", | ||
"@octokit/rest": "^21.0.2", | ||
|
@@ -110,8 +110,8 @@ | |
"@types/lodash": "^4.17.13", | ||
"@types/mocha": "^10.0.10", | ||
"@types/node": "^20.17.10", | ||
"@types/react": "^18.3.18", | ||
"@types/react-dom": "^18.3.5", | ||
"@types/react": "^19.0.2", | ||
"@types/react-dom": "^19.0.2", | ||
"@types/requestidlecallback": "^0.3.7", | ||
"@types/sinon": "^17.0.3", | ||
"@types/yargs": "^17.0.33", | ||
|
@@ -178,8 +178,8 @@ | |
"prettier": "^3.4.2", | ||
"pretty-quick": "^4.0.0", | ||
"process": "^0.11.10", | ||
"react": "^18.3.1", | ||
"react-dom": "^18.3.1", | ||
"react": "^19.0.0", | ||
"react-dom": "^19.0.0", | ||
Comment on lines
+181
to
+182
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. We should probably still test CI on react 18 though. It doesn't seem like There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Oh yeah, that is a great idea. There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I also need to setup periodic tests with React 18 on the core repo. Let me know if someone starts working on this on the X side 😊. There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I did not test it out Better is off course to have it automated, but could be useful until that is set up |
||
"remark": "^15.0.1", | ||
"rimraf": "^6.0.1", | ||
"serve": "^14.2.4", | ||
|
@@ -197,7 +197,7 @@ | |
"yargs": "^17.7.2" | ||
}, | ||
"resolutions": { | ||
"react-is": "^18.3.1", | ||
"react-is": "^19.0.0", | ||
"@types/node": "^20.17.10" | ||
}, | ||
"packageManager": "[email protected]", | ||
|
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -8,7 +8,8 @@ | |
"mocha", | ||
"node" | ||
], | ||
"noImplicitAny": false | ||
"noImplicitAny": false, | ||
"skipLibCheck": true | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Added these to avoid |
||
}, | ||
"include": ["src/**/*", "../../test/utils/addChaiAssertions.ts"] | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
How does it know it should trigger the
test-react-18
workflow?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
When pipeline is triggered on a filtered branch.
I have tested it on this branch by adding
renovate/react-major
. 😉I assume this will cause every CI to run on those branches to additionally test on React 18. 🤔
Would you rather go for a nightly cron job?
My thought process:
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No, I think running on selected branches is optimal solution.
It's just that I don't quite get how
test-react-18-context
andtest-react-18
are related.If the filters in the
test-react-18-context
are passed, does it automatically run all jobs that are tied to thetest-react-18-context
?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
test-react-18-context
is basically a reusable "variable" to avoid duplicating the same config for every test.Without this, every job after L436 would get the following diff: