Switch to Dialog and ViewTransition API #7554
Open
+442
−911
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
These will no longer be needed when we switch to the ViewTransition API for view transitions. It feels unnecessary to merge a suboptimal solution in the meanwhile.
raksooo
force-pushed
the
test-new-js-and-css-apis
branch
from
6e1cd1e to
e6fe6b1
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR replaces our old modal implementation with the Dialog element and our old transition implementation (TransitionContainer.tsx) with a slimmer solution using the ViewTransition API.
This change is