Open the store page on fdroid versions when clicking on version info

[Pururun]

---

This change is 

[linear]

DROID-1443 Link to Fdroid app page instead of download page for fdroid builds

[albin-mullvad]

Reviewed 5 of 5 files at r1, all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @Pururun)

---

android/app/src/main/kotlin/net/mullvad/mullvadvpn/viewmodel/ConnectViewModel.kt line 187 at r1 (raw file):

            val uri =
                if (isPlayBuild || isFdroidBuild) {
                    resources.getString(R.string.market_uri, packageName)

I believe this might open the "wrong" marketplace since we have identical package names atm. E.g. if Google Play is your default marketplace, but you install the build using the F-Droid app. Not sure if there's a good way of handling that case. Or is it already handled without me understanding how? 🤔

[Pururun]

Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @albin-mullvad)

---

android/app/src/main/kotlin/net/mullvad/mullvadvpn/viewmodel/ConnectViewModel.kt line 187 at r1 (raw file):

Previously, albin-mullvad wrote…

I believe this might open the "wrong" marketplace since we have identical package names atm. E.g. if Google Play is your default marketplace, but you install the build using the F-Droid app. Not sure if there's a good way of handling that case. Or is it already handled without me understanding how? 🤔

Good feedback. I can check and see what happens.

[Pururun]

Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @albin-mullvad)

---

android/app/src/main/kotlin/net/mullvad/mullvadvpn/viewmodel/ConnectViewModel.kt line 187 at r1 (raw file):

Previously, Pururun (Jonatan Rhodin) wrote…

Good feedback. I can check and see what happens.

I tested it on both the Google Play version and on this PR and you get a choice on which app to use since I guess both app marketplaces uses this schema. I can check and see if there is way to force a certain marketplace.

[Pururun]

Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @albin-mullvad)

---

android/app/src/main/kotlin/net/mullvad/mullvadvpn/viewmodel/ConnectViewModel.kt line 187 at r1 (raw file):

Previously, Pururun (Jonatan Rhodin) wrote…

I tested it on both the Google Play version and on this PR and you get a choice on which app to use since I guess both app marketplaces uses this schema. I can check and see if there is way to force a certain marketplace.

I checked the fdroid source code and as far as I can tell they are only checking for schema=marketand host=details" which means that using the format market://details?id={id}` which we use will always trigger any app market place that are the phone that support this format.

A potential solution could be to split the links to be direct links to the specific app marketplace, so use https://play.google.com/store/apps/details?id={id} and https://f-droid.org/en/packages/{id} instead.