-
Notifications
You must be signed in to change notification settings - Fork 47
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
remove unused graphql fields #1448
base: development
Are you sure you want to change the base?
Conversation
k6 load testing comparison.
Legend: Avg - Average Response Time, Max - Maximum Response Time, 90 - 90th Percentile, 95 - 95th Percentile |
const filteredPairs = this.applyFilters(mexPairs, filter); | ||
|
||
return filteredPairs.length; | ||
} | ||
|
||
async getAllMexPairsRaw(): Promise<MexPair[]> { | ||
async getAllMexPairsRaw(includeFarms: boolean = false): Promise<MexPair[]> { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
should we create a new class MexPairsOptions
or MexPairsFilter
that will contain the includeFarms
field? Passing a boolean to a function is not the best practice
Reasoning
Proposed Changes
How to test