[sovereign] Index reward txs in outport block #6638
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Base automatically changed from
MX-15587-finish-update-state-sovereign
to
feat/chain-go-sdk
November 29, 2024 13:56
| @@ -2116,6 +2116,9 @@ func checkProcessComponentsArgs(args ProcessComponentsFactoryArgs) error { | |||
| if check.IfNil(args.RunTypeComponents.ExportHandlerFactoryCreator()) { | |||
| return fmt.Errorf("%s: %w", baseErrMessage, errorsMx.ErrNilExportHandlerFactoryCreator) | |||
| } | |||
| if check.IfNil(args.RunTypeComponents.OutportDataProviderFactory()) { | |||
| return fmt.Errorf("%s: %w", baseErrMessage, errorsMx.ErrNilOutportDataProviderFactory) | |||
| } | |||
|
|
|||
There was a problem hiding this comment.
Missing nil check for APIRewardsTxHandler
There was a problem hiding this comment.
Because it's not being used anywhere here.
It is used and checked in CreateApiResolver
| pcf, err := processComp.NewProcessComponentsFactory(args) | ||
| require.True(t, errors.Is(err, errorsMx.ErrNilOutportDataProviderFactory)) | ||
| require.Nil(t, pcf) | ||
| }) |
There was a problem hiding this comment.
missing nil test for APIRewardsTxHandler
There was a problem hiding this comment.
No need, see the comment above
sasurobert
approved these changes
Dec 6, 2024
axenteoctavian
approved these changes
Dec 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reasoning behind the pull request
Proposed changes
APIRewardsTxHandlerinterface to return different results(normal vs sovereign run type) for reward txs when calling api routetransaction/:hashOutportDataProviderFactory(normal vs sovereign run type)sovereignChainBlockprocessingTesting procedure
Pre-requisites
Based on the Contributing Guidelines the PR author and the reviewers must check the following requirements are met:
featbranch created?featbranch merging, do all satellite projects have a proper tag insidego.mod?