Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

set fork detector checkpoints on bootstrapper applyBlock #6783

Merged
merged 6 commits into from
Feb 7, 2025

Conversation

AdoAdoAdo
Copy link
Contributor

Reasoning behind the pull request

  • bootstrapping after shuffling to other shards with equivalent proofs does not always succeed

Proposed changes

  • after applying the previously stored block, if this block has proofs, set the fork detector correspondingly.

Testing procedure

Pre-requisites

Based on the Contributing Guidelines the PR author and the reviewers must check the following requirements are met:

  • was the PR targeted to the correct branch?
  • if this is a larger feature that probably needs more than one PR, is there a feat branch created?
  • if this is a feat branch merging, do all satellite projects have a proper tag inside go.mod?

@AdoAdoAdo AdoAdoAdo marked this pull request as ready for review February 6, 2025 12:20
sstanculeanu
sstanculeanu previously approved these changes Feb 6, 2025
ssd04
ssd04 previously approved these changes Feb 6, 2025
@AdoAdoAdo AdoAdoAdo dismissed stale reviews from ssd04 and sstanculeanu via a715be2 February 6, 2025 16:39
@sstanculeanu sstanculeanu merged commit 3909d04 into feat/equivalent-messages Feb 7, 2025
4 checks passed
@sstanculeanu sstanculeanu deleted the bootstrap-fixes branch February 7, 2025 13:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants