Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sovereign chain simulator genesis file adaptation #6796

Merged

Conversation

axenteoctavian
Copy link
Contributor

@axenteoctavian axenteoctavian commented Feb 11, 2025

Reasoning behind the pull request

  • the chain simulator genesis file generation was changed in feat/chain-go-sdk and this introduced some problems in some tests that were using the initial wallets

Proposed changes

  • rollback GenerateGenesisFile with the one from rc
  • create GenerateSovereignGenesisFile

Testing procedure

Pre-requisites

Based on the Contributing Guidelines the PR author and the reviewers must check the following requirements are met:

  • was the PR targeted to the correct branch?
  • if this is a larger feature that probably needs more than one PR, is there a feat branch created?
  • if this is a feat branch merging, do all satellite projects have a proper tag inside go.mod?

@axenteoctavian axenteoctavian self-assigned this Feb 11, 2025
@axenteoctavian axenteoctavian marked this pull request as ready for review February 11, 2025 14:15
Copy link

📊 MultiversX Automated Test Report: View Report

🔄 Build Details:

  • mx-chain-go Commit Hash: ca238d5389f09bed6486a51e88c38123be03c004
  • Current Branch: MX-16519-chain-sim-config-adaptation
  • mx-chain-go Target Branch: feat/chain-go-sdk
  • mx-chain-simulator-go Target Branch: main
  • mx-chain-testing-suite Target Branch: main

🚀 Environment Variables:

  • TIMESTAMP: 11022025-142006
  • PYTEST_EXIT_CODE: 0
    🎉 MultiversX CI/CD Workflow Complete!

@sasurobert sasurobert self-requested a review February 11, 2025 14:39
@mariusmihaic mariusmihaic self-requested a review February 12, 2025 10:29
Copy link

📊 MultiversX Automated Test Report: View Report

🔄 Build Details:

  • mx-chain-go Commit Hash: 3fea782d76e5833fb48aa8a66674db536ea2e789
  • Current Branch: MX-16519-chain-sim-config-adaptation
  • mx-chain-go Target Branch: feat/chain-go-sdk
  • mx-chain-simulator-go Target Branch: main
  • mx-chain-testing-suite Target Branch: main

🚀 Environment Variables:

  • TIMESTAMP: 12022025-113935
  • PYTEST_EXIT_CODE: 0
    🎉 MultiversX CI/CD Workflow Complete!

Copy link

📊 MultiversX Automated Test Report: View Report

🔄 Build Details:

  • mx-chain-go Commit Hash: c83f6aa63b41ae577db42fe5cd7b6ba0debe8da8
  • Current Branch: MX-16519-chain-sim-config-adaptation
  • mx-chain-go Target Branch: feat/chain-go-sdk
  • mx-chain-simulator-go Target Branch: main
  • mx-chain-testing-suite Target Branch: main

🚀 Environment Variables:

  • TIMESTAMP: 12022025-125855
  • PYTEST_EXIT_CODE: 0
    🎉 MultiversX CI/CD Workflow Complete!

Copy link

📊 MultiversX Automated Test Report: View Report

🔄 Build Details:

  • mx-chain-go Commit Hash: f232155aaf3100ec801c8c738c308f7c8067696e
  • Current Branch: MX-16519-chain-sim-config-adaptation
  • mx-chain-go Target Branch: feat/chain-go-sdk
  • mx-chain-simulator-go Target Branch: main
  • mx-chain-testing-suite Target Branch: main

🚀 Environment Variables:

  • TIMESTAMP: 12022025-131333
  • PYTEST_EXIT_CODE: 0
    🎉 MultiversX CI/CD Workflow Complete!

Copy link

📊 MultiversX Automated Test Report: View Report

🔄 Build Details:

  • mx-chain-go Commit Hash: 0cb305e742a897698847fa1bc8c236ab3b36ce0d
  • Current Branch: MX-16519-chain-sim-config-adaptation
  • mx-chain-go Target Branch: feat/chain-go-sdk
  • mx-chain-simulator-go Target Branch: main
  • mx-chain-testing-suite Target Branch: main

🚀 Environment Variables:

  • TIMESTAMP: 12022025-143026
  • PYTEST_EXIT_CODE: 0
    🎉 MultiversX CI/CD Workflow Complete!

@axenteoctavian axenteoctavian merged commit 8e2c571 into feat/chain-go-sdk Feb 12, 2025
7 checks passed
@axenteoctavian axenteoctavian deleted the MX-16519-chain-sim-config-adaptation branch February 12, 2025 14:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants