Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add GitHub Actions workflow #7

Merged
merged 3 commits into from
Mar 15, 2024
Merged

Add GitHub Actions workflow #7

merged 3 commits into from
Mar 15, 2024

Conversation

Kissaki
Copy link
Member

@Kissaki Kissaki commented Mar 14, 2024

Travis CI does not run anymore.

The GitHub Actions workflow builds and runs, but the nss encrypt fails at runtime with error code -8190 - and PR_GetErrorText does not return text for it.

I don't see how to fix it so suggest we merge as-is (the other tests are run and results are output for them), or to drop nss.

@Kissaki Kissaki requested a review from davidebeatrici March 14, 2024 16:49
@davidebeatrici
Copy link
Member

davidebeatrici commented Mar 15, 2024

efa8a31 fixes a similar error (-8173, SEC_ERROR_NO_MEMORY).

This one is SEC_ERROR_BAD_DATA, I'll investigate why.

@Kissaki
Copy link
Member Author

Kissaki commented Mar 15, 2024

I'll investigate why

You approved anyway, so I assume you're suggesting to merge and you will investigate after.

@Kissaki Kissaki merged commit 93a4985 into master Mar 15, 2024
0 of 2 checks passed
@Kissaki Kissaki deleted the ci branch March 15, 2024 07:56
@davidebeatrici
Copy link
Member

Correct.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants