Make IEC traffic identification more precise #580
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
glaslos
reviewed
Dec 24, 2024
| @@ -80,38 +80,29 @@ def handle(self, sock, address): | |||
| request += new_byte | |||
|
|
|||
| # check if IEC 104 packet or for the first occurrence of the indication 0x68 for IEC 104 | |||
There was a problem hiding this comment.
This comment should be updated since you are not looking for the first occurrence anymore.
glaslos
requested changes
Dec 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR aims at making the traffic identification for the IEC server more robust by looking exactly at the first byte of the incoming data. The following log entry shows that a HTTP request was falsely identified as IEC traffic: