test: e2e

n8n-io · Jan 15, 2025 · 005ef5d · 005ef5d
1 parent f08905f
commit 005ef5d
Show file tree

Hide file tree

Showing 4 changed files with 13 additions and 7 deletions.
diff --git a/cypress/e2e/23-variables.cy.ts b/cypress/e2e/23-variables.cy.ts
@@ -65,8 +65,11 @@ describe('Variables', () => {
 			const editingRow = variablesPage.getters.variablesEditableRows().eq(0);
 			variablesPage.actions.setRowValue(editingRow, 'key', key);
 			variablesPage.actions.setRowValue(editingRow, 'value', value);
-			editingRow.should('contain', 'This field may contain only letters');
-			variablesPage.getters.editableRowSaveButton(editingRow).should('be.disabled');
+			variablesPage.actions.saveRowEditing(editingRow);
+			variablesPage.getters
+				.variablesEditableRows()
+				.eq(0)
+				.should('contain', 'This field may contain only letters');
 			variablesPage.actions.cancelRowEditing(editingRow);
 
 			variablesPage.getters.variablesRows().should('have.length', 3);

diff --git a/cypress/pages/variables.ts b/cypress/pages/variables.ts
@@ -68,7 +68,10 @@ export class VariablesPage extends BasePage {
 		},
 		setRowValue: (row: Chainable<JQuery<HTMLElement>>, field: 'key' | 'value', value: string) => {
 			row.within(() => {
-				cy.getByTestId(`variable-row-${field}-input`).type('{selectAll}{del}').type(value);
+				cy.getByTestId(`variable-row-${field}-input`)
+					.find('input, textarea')
+					.type('{selectAll}{del}')
+					.type(value);
 			});
 		},
 		cancelRowEditing: (row: Chainable<JQuery<HTMLElement>>) => {

diff --git a/packages/editor-ui/src/components/VariablesForm.vue b/packages/editor-ui/src/components/VariablesForm.vue
@@ -83,10 +83,10 @@ const handleSubmit = () => {
 				class="key-input"
 				label=""
 				name="value"
-				data-test-id="variable-row-key-input"
+				data-test-id="variable-row-value-input"
 				:placeholder="i18n.baseText('variables.editing.value.placeholder')"
 				type="textarea"
-				autosize
+				:autosize="{ minRows: 1, maxRows: 6 }"
 				size="medium"
 				:maxlength="VALUE_MAX_LENGTH"
 				:validate-on-blur="validateOnBlur"

diff --git a/packages/editor-ui/src/views/VariablesView.vue b/packages/editor-ui/src/views/VariablesView.vue
@@ -383,8 +383,8 @@ onMounted(() => {
 
 	.variables-key-column,
 	.variables-usage-column {
-		width: 300px;
-		min-width: 300px;
+		width: 25%;
+		min-width: 200px;
 	}
 
 	.variables-value-column {