-
Notifications
You must be signed in to change notification settings - Fork 10.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(Slack Node): Fix @version issue in param editor #12089
base: master
Are you sure you want to change the base?
Conversation
Hey @anatolinicolae, Thanks for the PR, We have created "GHC-578" as the internal reference to get this reviewed. One of us will be in touch if there are any changes needed, in most cases this is normally within a couple of weeks but it depends on the current workload of the team. |
A better solution might be to use the "gte" condition so it applies to all future versions as well. |
@Joffcom that's what I wanted to do at first, but yeah don't really know how impacting will future slack lib updates be. Do we want to yolo it with the "gte" condition? |
@anatolinicolae yes that is exactly what we want to do as this change was introduced as part of Slacks api update so this won't change again unless Slacks changes something. |
@anatolinicolae Hi, I think you can fix the same issue in FileDescription.ts. |
4e67e76
to
2fa6df7
Compare
Should be reflecting pretty much all changes from #12177 now, thanks @GimmyHchs! 🙌 |
@anatolinicolae Hi, I found an issue during manual testing and hope it can be addressed together. I apologize for any inconvenience caused. 🙏 Here is a reference for the fix commit: GimmyHchs@35906bf
btw, I think the PR title can be changed to |
Cherry-picked your commit 👍 |
01803ac
to
f94e8c1
Compare
Hi @Joffcom |
f2a48ca
to
d013b1d
Compare
d013b1d
to
46f76c6
Compare
Slack node version was bumped to 2.3 but this one keeps the prop field hidden in the UI
Summary
Can't pick file prop in the UI when using "Upload file" node for Slack, so I'm adding the new version on prop show condition.
Related PRs
Review / Merge checklist
release/backport
(if the PR is an urgent fix that needs to be backported)