Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(editor): Optionally share credentials used by the workflow when moving the workflow between projects #12524

Open
wants to merge 11 commits into
base: master
Choose a base branch
from

Conversation

cstuncsik
Copy link
Contributor

@cstuncsik cstuncsik commented Jan 9, 2025

Summary

If a user moves a workflow to a different project, they can optionally choose to share the credentials used by the workflow (if any) with the destination project.
Only the credentials the user has access to will be shared.

Related Linear tickets, Github issues, and Community forum posts

PAY-1745

Review / Merge checklist

  • PR title and summary are descriptive. (conventions)
  • Docs updated or follow-up ticket created.
  • Tests included.
  • PR Labeled with release/backport

@n8n-assistant n8n-assistant bot added n8n team Authored by the n8n team ui Enhancement in /editor-ui or /design-system labels Jan 9, 2025
Copy link

cypress bot commented Jan 10, 2025

n8n    Run #8711

Run Properties:  status check passed Passed #8711  •  git commit d0f3a10f43: 🌳 pay-1745-update-moved-workflow-to-include-option-to-share-credentials 🖥️ bro...
Project n8n
Branch Review pay-1745-update-moved-workflow-to-include-option-to-share-credentials
Run status status check passed Passed #8711
Run duration 04m 56s
Commit git commit d0f3a10f43: 🌳 pay-1745-update-moved-workflow-to-include-option-to-share-credentials 🖥️ bro...
Committer Csaba Tuncsik
View all properties for this run ↗︎

Test results
Tests that failed  Failures 0
Tests that were flaky  Flaky 0
Tests that did not run due to a developer annotating a test with .skip  Pending 0
Tests that did not run due to a failure in a mocha hook  Skipped 0
Tests that passed  Passing 489
View all changes introduced in this branch ↗︎

Copy link

codecov bot commented Jan 10, 2025

Codecov Report

Attention: Patch coverage is 81.18812% with 19 lines in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
...c/components/Projects/ProjectMoveResourceModal.vue 87.09% 10 Missing and 2 partials ⚠️
packages/editor-ui/src/stores/projects.store.ts 0.00% 5 Missing ⚠️
packages/editor-ui/src/api/workflows.ee.ts 33.33% 2 Missing ⚠️

📢 Thoughts on this report? Let us know!

@cstuncsik cstuncsik marked this pull request as ready for review January 15, 2025 16:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
n8n team Authored by the n8n team ui Enhancement in /editor-ui or /design-system
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants