feat(editor): VariablesView Reskin - Add Filters for missing values #12611
Conversation
n8n-assistant
bot
added
n8n team
|
Hey, I noticed that the validation message gets cut off in the Key field. Could we make the first column (Key) of the table wider, so that it has the same width than the second column (Value)? Also, let's update the tag and filter to "Needs attention" to match what was discussed in Linear 
|
I missed the "Needs attention" thanks!! About the column size, what i can do is only set the width of the actions column and the rest will auto adjust to the content. wdyt @Tuukkaa ?
|
Codecov ReportAttention: Patch coverage is
📢 Thoughts on this report? Let us know! |
|
@r00gm can we adjust the table so that the Key, Value and Usage syntax always take the same width, and the actions take the least possible space? With CSS grid it would be something like: |
done! |
|
Hey Raul, I got a confused between the Variables and Credentials table. I actually think that in this variables table it would be better to:
I updated the Figma design here. |
There was a problem hiding this comment.
the table is only used in the Variables Page. Reskin asked by design
| @@ -50,6 +50,7 @@ export interface Props { | |||
| inactiveColor?: string; | |||
| teleported?: boolean; | |||
| tagSize?: 'small' | 'medium' | 'large'; | |||
| autosize?: boolean | { minRows: number; maxRows: number }; | |||
There was a problem hiding this comment.
enable autosize textarea
https://element-plus.org/en-US/component/input.html#autosize-textarea
There was a problem hiding this comment.
this component replaces packages/editor-ui/src/components/VariablesRow.vue
There was a problem hiding this comment.
implemented testing pinia
test filters
test sorting
test CRUD
r00gm
changed the title
…ight-empty-variables-to
Summary
Table reskin
Filters
Related Linear tickets, Github issues, and Community forum posts
PAY-2459
Review / Merge checklist
release/backport(if the PR is an urgent fix that needs to be backported)