fix(editor): Show run workflow button when chat trigger has pinned data #12616
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jeanpaul
changed the title
n8n-assistant
bot
added
n8n team
Codecov ReportAll modified and coverable lines are covered by tests ✅ 📢 Thoughts on this report? Let us know! |
alexgrozav
approved these changes
Jan 15, 2025
|
|
n8n
|
||||||||||||||||||||||||||||
| Project |
n8n
|
| Branch Review |
master
|
| Run status |
|
| Run duration | 04m 49s |
| Commit |
|
| Committer | jeanpaul |
| View all properties for this run ↗︎ | |
| Test results | |
|---|---|
Failures
|
0
|
Flaky
|
0
|
Pending
|
0
|
Skipped
|
0
|
Passing
|
489
|
| View all changes introduced in this branch ↗︎ | |
|
✅ All Cypress E2E specs passed |
jeanpaul
deleted the
ai-590-bug-execute-workflow-button-missing-when-chat-is-pinned
branch
adrian-martinez-onestic
pushed a commit
to onesdata/n8n-fork
that referenced
this pull request
Jan 17, 2025
adrian-martinez-onestic
pushed a commit
to onesdata/n8n-fork
that referenced
this pull request
Jan 17, 2025
adrian-martinez-onestic
pushed a commit
to onesdata/n8n-fork
that referenced
this pull request
Jan 17, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This change modifies the visibility condition for the Run Workflow button in the NodeView component. Previously, the button was hidden when the Chat Trigger node was the only active trigger. The change now allows the button to be visible in two scenarios:
This adjustment improves the user experience by providing the option to run the workflow even when a Chat Trigger node with pinned data is the only active node in the workflow.
Related Linear tickets, Github issues, and Community forum posts
https://linear.app/n8n/issue/AI-590/bug-execute-workflow-button-missing-when-chat-is-pinned
Review / Merge checklist
release/backport(if the PR is an urgent fix that needs to be backported)