fix(editor): Show connector label above the line when it's straight #12622
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
autologie
commented
Jan 15, 2025
There was a problem hiding this comment.
In this file I'm changing how the label position is calculated for the "handle", while maintaining how it looks.
With top: 50%, the origin of translation is the same as the connector's, so we can use the same -150% to bring the label above the line.
n8n-assistant
bot
added
n8n team
Codecov ReportAll modified and coverable lines are covered by tests ✅ 📢 Thoughts on this report? Let us know! |
mutdmour
reviewed
Jan 16, 2025
packages/editor-ui/src/components/canvas/elements/edges/CanvasEdge.vue
Outdated
Show resolved
Hide resolved
|
@mutdmour Tests are added, could you have another look? Thanks. |
mutdmour
approved these changes
Jan 16, 2025
|
✅ All Cypress E2E specs passed |
n8n
|
||||||||||||||||||||||||||||
| Project |
n8n
|
| Branch Review |
sug-4-label-on-straight-connector
|
| Run status |
|
| Run duration | 04m 50s |
| Commit |
|
| Committer | autologie |
| View all properties for this run ↗︎ | |
| Test results | |
|---|---|
Failures
|
0
|
Flaky
|
1
|
Pending
|
0
|
Skipped
|
0
|
Passing
|
489
|
| View all changes introduced in this branch ↗︎ | |
adrian-martinez-onestic
pushed a commit
to onesdata/n8n-fork
that referenced
this pull request
Jan 17, 2025
adrian-martinez-onestic
pushed a commit
to onesdata/n8n-fork
that referenced
this pull request
Jan 17, 2025
adrian-martinez-onestic
pushed a commit
to onesdata/n8n-fork
that referenced
this pull request
Jan 17, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR fixes the position of connector label in the new editor canvas, so that the label does not overlap the connector's line when it's straight.
Before
After
Related Linear tickets, Github issues, and Community forum posts
https://linear.app/n8n/issue/SUG-4/connection-label-should-jump-above-line-if-the-line-is-straight
Review / Merge checklist
release/backport(if the PR is an urgent fix that needs to be backported)