-
Notifications
You must be signed in to change notification settings - Fork 11.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Sync partial execution version of FE and BE, also allow enforcing a specific version #12840
Open
despairblue
wants to merge
8
commits into
master
Choose a base branch
from
fix-and-force-partial-execution-settings
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…g a specific version
n8n-assistant
bot
added
core
Enhancement outside /nodes-base and /editor-ui
n8n team
Authored by the n8n team
ui
Enhancement in /editor-ui or /design-system
labels
Jan 24, 2025
despairblue
changed the title
fix: sync partial execution version of FE and BE, also allow enforcing a specific version
fix: Sync partial execution version of FE and BE, also allow enforcing a specific version
Jan 24, 2025
Codecov ReportAttention: Patch coverage is
📢 Thoughts on this report? Let us know! |
cstuncsik
approved these changes
Jan 30, 2025
✅ All Cypress E2E specs passed |
n8n Run #9037
Run Properties:
|
Project |
n8n
|
Branch Review |
fix-and-force-partial-execution-settings
|
Run status |
Passed #9037
|
Run duration | 04m 21s |
Commit |
6bc49ab853: 🌳 🖥️ browsers:node18.12.0-chrome107 🤖 despairblue 🗃️ e2e/*
|
Committer | Danny Martini |
View all properties for this run ↗︎ |
Test results | |
---|---|
Failures |
0
|
Flaky |
3
|
Pending |
5
|
Skipped |
0
|
Passing |
430
|
View all changes introduced in this branch ↗︎ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
partialExecutionVersion
query param1
means version 1 and2
means version 2 (opposed to 0 -> v1 and 1 -> v2)I'm not sure if I used the settings store correctly, but I tested changing the local storage key and it worked and updated it.
Related Linear tickets, Github issues, and Community forum posts
Review / Merge checklist
Docs updated or follow-up ticket created.Tests included.PR Labeled withrelease/backport
(if the PR is an urgent fix that needs to be backported)