Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Sync partial execution version of FE and BE, also allow enforcing a specific version #12840

Open
wants to merge 8 commits into
base: master
Choose a base branch
from

Conversation

despairblue
Copy link
Contributor

@despairblue despairblue commented Jan 24, 2025

Summary

  • use DTOs for the partialExecutionVersion query param
  • move partial execution feature flag to configuration to config package
  • redefine config: 1 means version 1 and 2 means version 2 (opposed to 0 -> v1 and 1 -> v2)
  • add an additional env var to allow forcing the default version for everybody (this is to catch more bugs on our internal instance)

I'm not sure if I used the settings store correctly, but I tested changing the local storage key and it worked and updated it.

Related Linear tickets, Github issues, and Community forum posts

Review / Merge checklist

  • PR title and summary are descriptive. (conventions)
  • Docs updated or follow-up ticket created.
  • Tests included.
  • PR Labeled with release/backport (if the PR is an urgent fix that needs to be backported)

@n8n-assistant n8n-assistant bot added core Enhancement outside /nodes-base and /editor-ui n8n team Authored by the n8n team ui Enhancement in /editor-ui or /design-system labels Jan 24, 2025
@despairblue despairblue changed the title fix: sync partial execution version of FE and BE, also allow enforcing a specific version fix: Sync partial execution version of FE and BE, also allow enforcing a specific version Jan 24, 2025
Copy link

codecov bot commented Jan 27, 2025

Codecov Report

Attention: Patch coverage is 90.90909% with 2 lines in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
packages/cli/src/manual-execution.service.ts 0.00% 0 Missing and 1 partial ⚠️
packages/editor-ui/src/stores/workflows.store.ts 50.00% 1 Missing ⚠️

📢 Thoughts on this report? Let us know!

@despairblue despairblue marked this pull request as ready for review January 27, 2025 17:59
Copy link
Contributor

✅ All Cypress E2E specs passed

Copy link

cypress bot commented Jan 30, 2025

n8n    Run #9037

Run Properties:  status check passed Passed #9037  •  git commit 6bc49ab853: 🌳 🖥️ browsers:node18.12.0-chrome107 🤖 despairblue 🗃️ e2e/*
Project n8n
Branch Review fix-and-force-partial-execution-settings
Run status status check passed Passed #9037
Run duration 04m 21s
Commit git commit 6bc49ab853: 🌳 🖥️ browsers:node18.12.0-chrome107 🤖 despairblue 🗃️ e2e/*
Committer Danny Martini
View all properties for this run ↗︎

Test results
Tests that failed  Failures 0
Tests that were flaky  Flaky 3
Tests that did not run due to a developer annotating a test with .skip  Pending 5
Tests that did not run due to a failure in a mocha hook  Skipped 0
Tests that passed  Passing 430
View all changes introduced in this branch ↗︎

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
core Enhancement outside /nodes-base and /editor-ui n8n team Authored by the n8n team ui Enhancement in /editor-ui or /design-system
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants