Skip to content

Commit

Permalink
Bump the range of supported Ruby versions
Browse files Browse the repository at this point in the history
## Ruby 3.4 is out
### 1. Add Bundled gems for Ruby 3.4

https://bugs.ruby-lang.org/issues/20187

It has already been backported to the 7-0-stable branch, but is not included in 7.0.8.7.
- https://github.com/rails/rails/blob/7-0-stable/activesupport/activesupport.gemspec#L41-L43
- https://github.com/rails/rails/blob/v7.0.8.7/activesupport/activesupport.gemspec

### 2. concurrent-ruby 1.3.5 don't work on Rails 7.0

> NameError:
>  uninitialized constant ActiveSupport::LoggerThreadSafeLevel::Logger

See: ruby-concurrency/concurrent-ruby#1062
  • Loading branch information
naitoh committed Jan 17, 2025
1 parent 6f249c8 commit 7e9d635
Show file tree
Hide file tree
Showing 2 changed files with 6 additions and 1 deletion.
3 changes: 2 additions & 1 deletion .github/workflows/ci.yml
Original file line number Diff line number Diff line change
Expand Up @@ -24,6 +24,7 @@ jobs:
- "3.1"
- "3.2"
- "3.3"
- "3.4"
gemfile:
- gemfiles/rails_7_0.gemfile
- gemfiles/rails_7_1.gemfile
Expand Down Expand Up @@ -56,7 +57,7 @@ jobs:
- name: Setup Ruby
uses: ruby/setup-ruby@v1
with:
ruby-version: "3.3"
ruby-version: "3.4"
bundler-cache: true
- run: bundle exec rake spec || echo "Rails edge test is done."

Expand Down
4 changes: 4 additions & 0 deletions gemfiles/rails_7_0.gemfile
Original file line number Diff line number Diff line change
Expand Up @@ -18,5 +18,9 @@ gem "sprockets-rails"
gem "sqlite3", "~> 1.4", platform: [:ruby, :mswin, :mingw, :x64_mingw]
gem "tzinfo-data", platforms: [:mingw, :mswin, :x64_mingw]
gem "timecop"
gem "base64"
gem "drb"
gem "mutex_m"
gem "concurrent-ruby", "1.3.4"

gemspec path: "../"

0 comments on commit 7e9d635

Please sign in to comment.