Add ability to open Trello card in desktop app

[ChrisChinchilla]

As far as I can tell, there is only a Windows and macOS desktop application.

[nathonius]

Looks pretty good! I think this is a great addition.

[nathonius]

I'm fine with hiding this setting on other platforms, as long as we also override the saved settings on other platforms. I think a check in plugin.ts after loading settings, but before initializing the state:

    // Set up data and default data.
    const savedData: PluginData | undefined = await this.loadData();
    const data: PluginData = Object.assign({}, DEFAULT_DATA, savedData);
    data.settings = Object.assign({}, DEFAULT_SETTINGS, savedData?.settings);
    data.settings.customUi = Object.assign({}, DEFAULT_SETTINGS.customUi, savedData?.settings.customUi);

    // Add something like this
    if (!Platform.isWin && !Platform.isMacOS) {
        data.settings.openInDesktop = false;
    }

    this.state = new PluginState(this, data);

It's not a big deal but I know I use a synced obsidian vault on multiple platforms. I wouldn't want someone to enable it on a Mac, then open Obsidian on Linux and have everything be broken.

[ChrisChinchilla]

@nathonius OK, I will need to test this, and it's a busy week, leave it with me

[ChrisChinchilla]

@nathonius Added, but I am finding it really hard to test, as everything still shows on iPad and actually still opens in the iPad Trello app anyway 🤷 . Do you have a way to test on Linux?

[nathonius]

Yeah I can test on a Linux desktop. Will do that in the next day or two. Maybe Android would work too? I can modify to allow the setting there and see if it opens the Trello app.

[nathonius]

While you're in plugin.ts, I just noticed I spelled Obsidian wrong in the log function 🤣

  log(context: string, message: string, logLevel: LogLevel = LogLevel.Info): void {
    if (this.state.getSetting('verboseLogging')) {
      const log = `OBISIDAN-TRELLO: (${context}) ${message}`;

[ChrisChinchilla]

@nathonius I guess most people don't look… Fixed it in this PR.

[nathonius]

Let's get those few changes in here and we can get this merged and released. 😄

[sonarqubecloud]

Quality Gate passed

Issues
1 New issue

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

[nathonius]

Looks great. I'm going to try testing on Linux but otherwise I think this is good for release.