Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(apple): create an updatable pass (#53) #55

Merged

Conversation

aahna-ashina
Copy link
Member

@aahna-ashina aahna-ashina commented Aug 20, 2022

Dework Task

https://app.dework.xyz/nation3/app-2?taskId=063a5647-479d-47aa-ba6a-fbf3369acd8e

Related GitHub Issue

close #53

Features Implemented

  • 82bb53f Add 2nd template version
  • 54f5299 Add a web service to update the pass
  • 545e4b4 Set the shared secret (authentication token) to be used with the web service

How Has This Been Tested?

  • Test generation of new .pkass files, and verify that pass.json contains the two new variables.
  • Install generated pass on iOS device, and verify that a request to webServiceURL was made
    request

Remaining Admin Tasks

Tasks to handle before merging this PR:

  • Add APPLE_AUTH_TOKEN_HMAC_SEED environment variable to Vercel deployment for https://passports.nation3.org/
    Note: Different from the value in .env.local.goerli
  • Add APPLE_WEB_SERVICE_URL environment variable to Vercel deployment for https://passports.nation3.org/
    Note: Same as the value in .env.local.mainnet

@aahna-ashina aahna-ashina self-assigned this Aug 20, 2022
@vercel
Copy link

vercel bot commented Aug 20, 2022

@aahna-ashina is attempting to deploy a commit to the Nation3 Team on Vercel.

A member of the Team first needs to authorize it.

@aahna-ashina aahna-ashina marked this pull request as ready for review August 23, 2022 04:38
@vercel
Copy link

vercel bot commented Aug 23, 2022

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
mobile-passport ✅ Ready (Inspect) Visit Preview Aug 23, 2022 at 8:52AM (UTC)

@luisivan
Copy link
Contributor

@aahna-ashina can you provide more info about how to obtain APPLE_AUTH_TOKEN_HMAC_SEED and APPLE_WEB_SERVICE_URL? Thanks!

@aahna-ashina
Copy link
Member Author

aahna-ashina commented Aug 24, 2022

can you provide more info about how to obtain APPLE_AUTH_TOKEN_HMAC_SEED and APPLE_WEB_SERVICE_URL? Thanks!

@luisivan Yes 😄

  • The APPLE_AUTH_TOKEN_HMAC_SEED variable can be any random string of characters, it just needs to be different from the one used in .env.local.goerli

    • Also note that once set, this variable should never be changed.
  • The APPLE_WEB_SERVICE_URL must match the domain used for the Vercel deployment:

    • APPLE_WEB_SERVICE_URL=https://passports.nation3.org/api/apple

Could you help me add these two variables to Vercel?

@luisivan
Copy link
Contributor

@aahna-ashina thanks, done!

Copy link
Contributor

@johnmark13 johnmark13 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tiny change, always great work 💪

server/pages/api/pushUpdate.ts Show resolved Hide resolved
Copy link
Contributor

@luisivan luisivan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Solid

@aahna-ashina aahna-ashina merged commit e94fe6c into nation3:main Aug 30, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Create an updatable pass
3 participants