Refactor Apple Wallet code (#76)

[aahna-ashina]

Dework Task

https://app.dework.xyz/nation3/passport-services-p?taskId=ae6efa25-b222-4700-afc8-63e65b870cb9

Related GitHub Issue

#76

• df21a4d Add a simple helper for the to/from milliseconds calculations
• ecf3d0c Reduce the number of branches of code in [passTypeIdentifier].ts (Apple Wallet: Send Notification Requests to APNs (#78) #79 (comment))
• bbfa591 Separate APN provider code in Passes.ts into a standalone file/function (Apple Wallet: Send Notification Requests to APNs (#78) #79 (comment))

Improve stability of APNs integration:

• 36f5e8d Improve asynchronous calls to APNs in Passes.ts, so that a JSON response is not returned until all notification requests have been confirmed by APNs.

How Has This Been Tested?

• Status checks pass
• 138492a Mock APN provider during unit tests
• Increased code coverage from 80% to 85%
• Works on Goerli
• Works on Mainnet

Are There Admin Tasks?

Nada

[vercel]

@aahna-ashina is attempting to deploy a commit to the Nation3 Team on Vercel.

A member of the Team first needs to authorize it.

[codecov-commenter]

Codecov Report

Merging #91 (a62f5a1) into main (2182909) will increase coverage by 5.08%.
The diff coverage is 73.07%.

@@            Coverage Diff             @@
##             main      #91      +/-   ##
==========================================
+ Coverage   80.88%   85.96%   +5.08%     
==========================================
  Files           5        7       +2     
  Lines         204      228      +24     
  Branches       23       26       +3     
==========================================
+ Hits          165      196      +31     
+ Misses         38       30       -8     
- Partials        1        2       +1     

Impacted Files	Coverage Δ
server/utils/APNProvider.ts	0.00% <0.00%> (ø)
server/utils/Passes.ts	94.40% <89.28%> (+14.40%)	⬆️
server/utils/DateUtils.ts	100.00% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

[aahna-ashina]

@luisivan This PR improves calls to /api/pushLastUpdate by returning a more detailed JSON response:

{
    "summary": "1 sent, 3 failed",
    "sent": [ ... ],
    "failed": [ ... ]
}

Also the code is changed from async to await, so that a response is not returned until all push notification requests have been sent to Apple. For now, the waiting time is just a few seconds. And in the future, with hundreds/thousands of registered passes, we should improve the user experience by building a UI where you can see a progress bar while sending out pass update notifications and waiting for them to complete.

[johnmark13]

😄

[aahna-ashina]

How sad 🥲

[aahna-ashina]

@luisivan @okhaimie-dev @xPi2 Need your review before merging 🙏

[aahna-ashina]

@johnmark13 Added mocking: 138492a

[xPi2]

LGTM, but maybe I'm missing enough context to give better feedback.

[johnmark13]

I think this is really clever 💪

[johnmark13]

💪