Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Sf pdl kafka #301

Merged
merged 159 commits into from
Sep 18, 2024
Merged

Sf pdl kafka #301

merged 159 commits into from
Sep 18, 2024

Conversation

nocturnalnematode
Copy link
Contributor

new classes for handling new pdl and gt kafka queues

@nocturnalnematode nocturnalnematode requested a review from a team as a code owner July 3, 2024 16:12
@nocturnalnematode nocturnalnematode force-pushed the sf-pdl-kafka branch 2 times, most recently from bec03dd to e15b9bf Compare July 5, 2024 17:37
Triopticon
Triopticon reviewed Aug 14, 2024
View reviewed changes
force-app/main/default/classes/KafkaMessageHandler.cls Show resolved Hide resolved
force-app/main/default/classes/KafkaMessageHandler.cls Outdated Show resolved Hide resolved
force-app/main/default/classes/KafkaMessageHandlerTest.cls Show resolved Hide resolved
force-app/main/default/classes/KafkaMessageService.cls Outdated Show resolved Hide resolved
force-app/main/default/classes/KafkaMessageService.cls Show resolved Hide resolved
force-app/pdl-handler/classes/KafkaPdlPersondokumentHandler.cls Show resolved Hide resolved
force-app/pdl-handler/classes/KafkaPdlPersondokumentHandler.cls Show resolved Hide resolved
force-app/pdl-handler/classes/KafkaPdlPersondokumentHandler.cls Show resolved Hide resolved
force-app/pdl-handler/classes/KafkaPdlPersondokumentHandlerTest.cls Outdated Show resolved Hide resolved
force-app/pdl-handler/classes/KafkaPdlPersondokumentHandlerTest.cls Show resolved Hide resolved
@nocturnalnematode
minor readme fix
d59b5b6
@nocturnalnematode
add a little test data for new pdl and gt topics
86c7340
@nocturnalnematode
POC – create person from GeografiskTilknytning
38a80b2
@nocturnalnematode
write failing test testCreatePersonFromPersonDo...
2929860
@nocturnalnematode
delete other tests for now; they use KafkaPerson2
fe109bb
@nocturnalnematode
create person with fnr
a7d3639
@nocturnalnematode
be born
e77783a
@nocturnalnematode
also allow being born in just a year
018c792
@nocturnalnematode
have name
83edb5b
@nocturnalnematode
set actor id and pass aforementioned test
41797c9
@nocturnalnematode
add empty document for testing, register handler
e957352
@nocturnalnematode
POC tombstone handling
498a674
@nocturnalnematode
clarify NPID and other idents
f3504d0
@nocturnalnematode
make setFolkeregisterIdents a bit more readable
529f1e6
@nocturnalnematode
add tombstone test, probably false negative
10864a5
@nocturnalnematode
add more tombstone tests, 3 fail
cea4185
@nocturnalnematode
minor
995b455
@nocturnalnematode
these weren't meant to be tombstones
5c956bf 
    pass every tombstone sanity check, only processTombstoneTest fails
@nocturnalnematode
simple tombstone check
16c9492
@nocturnalnematode
add setName test, create person, set status & more
08446a9
@nocturnalnematode
set everything else
1667c74 
    test now passes with correct exception
@nocturnalnematode
add and pass setNameTest
1e413fa
@nocturnalnematode
fix logic, pass test
24e4b03
@nocturnalnematode
add and pass insertKafkaMessageDefault
b518d00
@nocturnalnematode
add insertKafkaMessageProcessed test which fails
9e0ad9b
@nocturnalnematode
ditch the non-actorid-looking actorids
6e76862
nocturnalnematode and others added 26 commits September 11, 2024 09:13
@nocturnalnematode
use separate metadata for sandboxes. breaks tests.
41e96d5
@nocturnalnematode
fix PD_TOPIC in tests
799dd99
@nocturnalnematode
slightly increase pdl kafka handler priority
d2f6d22
@nocturnalnematode
write failing test for priority
ca91efc
@nocturnalnematode
read correct job type and priority
9548f23
@nocturnalnematode
minor cleanup
dcd295c
@nocturnalnematode
run sandbox test only in sandboxes
d683957
@nocturnalnematode
add field also to layout and list view
569d6c3
@nocturnalnematode
typo
46c2cec
@nocturnalnematode
drop unnecessary soql queries
7c6a000
@nocturnalnematode
fix exception when coordinates are null
dc02d24
@nocturnalnematode
update README
22268ac
@nocturnalnematode
apply some of the advice from npx prettier
92b459b
@nocturnalnematode
bump prettier and prettier-plugin-apex
c52675f
@nocturnalnematode
clarify test in KafkaMessageHandlerTest
4b457cf
@nocturnalnematode
test for IsSandbox in top level of classes
be1f62f
@nocturnalnematode
clarify need for SandboxOverrideTopic__c
72dfbb3
@nocturnalnematode
clarify constants
d3b98b1
@nocturnalnematode
clarify assignIdent
063d93e
@nocturnalnematode
expand non-loop single character variables
5550f9c
@nocturnalnematode
clarify method names
3d16bce
@nocturnalnematode
trim unnecessary sharing rules
9b6c5bf
@nocturnalnematode
cleanup
af86150
@nocturnalnematode
minor
1a6442e
@nocturnalnematode
rename tests
6c1b435
@nocturnalnematode
rename, and clarify comments for, persondok-tests
9896be1
@nocturnalnematode nocturnalnematode changed the base branch from master to main September 18, 2024 07:55
@nocturnalnematode nocturnalnematode merged commit 2f2df9e into main Sep 18, 2024
8 of 9 checks passed
@nocturnalnematode nocturnalnematode deleted the sf-pdl-kafka branch September 18, 2024 11:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Triopticon Triopticon Triopticon left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@nocturnalnematode @Triopticon