Ignorer duplikate hendelser #456
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
olekvernberg
requested review from
charliemidtlyng,
ViktorGSolberg,
ma10s,
throndi and
gunnsteingarmo
|
Men blir den ikke behandlet dobbelt nå? |
|
Edit: leste kode :D Hva er det vi håper å kunne håndtere bedre denne gangen (hvis vi tillater å håndtere meldingen en gang til) ? PDL: Kanskje bare logge WARNING, ikke kaste runtime hvis vi allerede har håndtert denne? |
ma10s
reviewed
Nov 7, 2023
src/main/kotlin/no/nav/familie/ef/personhendelse/kafka/PersonhendelseListener.kt
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
På grunn av en problemer med db hos PDL, må de sende ut hendelser på nytt fra fredag. Ignorerer nå duplikate hendelsesIds. Kommer til å ta inn igjen denne koden etter at personhendelse har lest siste meldingen, da vi ønsker å feile dersom det skulle skje i andre tilfeller.
https://nav-it.slack.com/archives/C020Q1K6EAY/p1699349632203809