BREAKING CHANGE: migrate to node test runner and fastify v5 #374
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
No linked issues found. Please add the corresponding issues in the pull request description. |
ilteoood
changed the title
simoneb
reviewed
Dec 17, 2024
| }) | ||
|
|
||
| t.test('sdk error', async (t) => { | ||
| test('sdk error', async (t) => { |
There was a problem hiding this comment.
We are awaiting the rejection
There was a problem hiding this comment.
I mean the test. I remember children tests needing awaiting, but I'm not sure if this applies all the time or it depends
There was a problem hiding this comment.
Oh Sorry. No, because we are using the describe on top.
simoneb
approved these changes
Dec 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Note: I was not able to test it locally as the credentials on the vault are expired.