Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: downgrade the next.js module federation plugin #98

Merged
merged 1 commit into from
Aug 10, 2023

Conversation

bredikhin
Copy link
Collaborator

Downgrades the Next.js module federation plugin version and adds an exception to the Dependabot config. The main reason for this is the presence of issues described in module-federation/core#1102.

@bredikhin bredikhin requested a review from coston August 10, 2023 19:42
@bredikhin bredikhin self-assigned this Aug 10, 2023
@github-actions
Copy link

No linked issues found. Please add the corresponding issues in the pull request description.
Use GitHub automation to close the issue when a PR is merged

Comment on lines +7 to +11
ignore:
# Pending complete resolution of https://github.com/module-federation/universe/issues/1102
# This exception should be removed as part of https://github.com/nearform/the-micro-frontends-workshop/issues/32
- dependency-name: "@module-federation/nextjs-mf"
versions: ["6.x", "7.x"]
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this needs to be removed as part of #32

Copy link
Contributor

@coston coston left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works for me!

@bredikhin bredikhin merged commit cc3b625 into master Aug 10, 2023
@bredikhin bredikhin deleted the chore-upgrade-module-federation-plugin branch August 10, 2023 23:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants