Fix up brokenness

neo4j · Jun 2, 2022 · 632893b · 632893b
1 parent 4d6faf5
commit 632893b
Show file tree

Hide file tree

Showing 4 changed files with 5 additions and 8 deletions.
diff --git a/doc/asciidoc/operations-reference/appendix-a-graph-algos.adoc b/doc/asciidoc/operations-reference/appendix-a-graph-algos.adoc
@@ -316,7 +316,7 @@ include::../algorithms/algorithm-tiers.adoc[]
 | `gds.alpha.leiden.mutate`
 | `gds.alpha.leiden.stats`
 | `gds.alpha.leiden.stream`
-.4+<.^| Filtered NodeSimilarity
+.6+<.^| Filtered NodeSimilarity
 | `gds.alpha.nodeSimilarity.filtered.mutate`
 | `gds.alpha.nodeSimilarity.filtered.mutate.estimate`
 | `gds.alpha.nodeSimilarity.filtered.stream`

diff --git a/open-packaging/src/test/java/org/neo4j/gds/OpenGdsProcedureSmokeTest.java b/open-packaging/src/test/java/org/neo4j/gds/OpenGdsProcedureSmokeTest.java
@@ -469,7 +469,7 @@ void countShouldMatch() {
         );
 
         // If you find yourself updating this count, please also update the count in SmokeTest.kt
-        int expectedCount = 323;
+        int expectedCount = 325;
         assertEquals(
             expectedCount,
             registeredProcedures.size(),

diff --git a/...c/main/java/org/neo4j/gds/similarity/filterednodesim/FilteredNodeSimilarityWriteProc.java b/...c/main/java/org/neo4j/gds/similarity/filterednodesim/FilteredNodeSimilarityWriteProc.java
@@ -43,16 +43,17 @@
 
 import static org.neo4j.gds.similarity.filterednodesim.FilteredNodeSimilarityStreamProc.DESCRIPTION;
 import static org.neo4j.procedure.Mode.READ;
+import static org.neo4j.procedure.Mode.WRITE;
 
-@GdsCallable(name = "gds.alpha.nodeSimilarity.filtered.write", description = DESCRIPTION, executionMode = ExecutionMode.STREAM)
+@GdsCallable(name = "gds.alpha.nodeSimilarity.filtered.write", description = DESCRIPTION, executionMode = ExecutionMode.WRITE_RELATIONSHIP)
 public class FilteredNodeSimilarityWriteProc extends WriteRelationshipsProc<
     NodeSimilarity,
     NodeSimilarityResult,
     SimilarityWriteResult,
     FilteredNodeSimilarityWriteConfig
     > {
 
-    @Procedure(value = "gds.alpha.nodeSimilarity.filtered.write", mode = READ)
+    @Procedure(value = "gds.alpha.nodeSimilarity.filtered.write", mode = WRITE)
     @Description(DESCRIPTION)
     public Stream<SimilarityWriteResult> write(
         @Name(value = "graphName") String graphName,

diff --git a/...c/main/java/org/neo4j/gds/similarity/filterednodesim/FilteredNodeSimilarityWriteSpec.java b/...c/main/java/org/neo4j/gds/similarity/filterednodesim/FilteredNodeSimilarityWriteSpec.java
@@ -26,9 +26,7 @@
 import org.neo4j.gds.core.write.RelationshipExporterBuilder;
 import org.neo4j.gds.executor.AlgorithmSpec;
 import org.neo4j.gds.executor.ComputationResultConsumer;
-import org.neo4j.gds.executor.GdsCallable;
 import org.neo4j.gds.executor.NewConfigFunction;
-import org.neo4j.gds.paths.delta.DeltaStepping;
 import org.neo4j.gds.similarity.SimilarityProc;
 import org.neo4j.gds.similarity.SimilarityWriteResult;
 import org.neo4j.gds.similarity.nodesim.NodeSimilarity;
@@ -38,9 +36,7 @@
 
 import static org.neo4j.gds.LoggingUtil.runWithExceptionLogging;
 import static org.neo4j.gds.core.ProcedureConstants.HISTOGRAM_PRECISION_DEFAULT;
-import static org.neo4j.gds.executor.ExecutionMode.WRITE_RELATIONSHIP;
 
-@GdsCallable(name = "gds.alpha.nodeSimilarity.filtered.write", description = DeltaStepping.DESCRIPTION, executionMode = WRITE_RELATIONSHIP)
 public class FilteredNodeSimilarityWriteSpec implements AlgorithmSpec<
     NodeSimilarity,
     NodeSimilarityResult,