Merge pull request #2668 from neos/task/drop-useless-unicode-safe-fun…

…ction TASK: Drop call to unicode-safe pathinfo()
neos · Mar 10, 2022 · 0a19f92 · 0a19f92
2 parents 6832106 + 405dbc2
commit 0a19f92
Showing 1 changed file with 4 additions and 4 deletions.
diff --git a/Neos.Flow/Classes/ResourceManagement/Target/FileSystemSymlinkTarget.php b/Neos.Flow/Classes/ResourceManagement/Target/FileSystemSymlinkTarget.php
@@ -14,10 +14,9 @@
 use Neos\Error\Messages\Error;
 use Neos\Flow\ResourceManagement\CollectionInterface;
 use Neos\Flow\ResourceManagement\Storage\PackageStorage;
+use Neos\Flow\ResourceManagement\Target\Exception as TargetException;
 use Neos\Flow\Utility\Algorithms;
 use Neos\Utility\Files;
-use Neos\Utility\Unicode\Functions as UnicodeFunctions;
-use Neos\Flow\ResourceManagement\Target\Exception as TargetException;
 
 /**
  * A target which publishes resources by creating symlinks.
@@ -58,8 +57,9 @@ public function publishCollection(CollectionInterface $collection, callable $cal
      */
     protected function publishFile($sourceStream, $relativeTargetPathAndFilename)
     {
-        $pathInfo = UnicodeFunctions::pathinfo($relativeTargetPathAndFilename);
-        if (isset($pathInfo['extension']) && array_key_exists(strtolower($pathInfo['extension']), $this->excludedExtensions) && $this->excludedExtensions[strtolower($pathInfo['extension'])] === true) {
+        $pathInfo = pathinfo($relativeTargetPathAndFilename);
+        $extension = isset($pathInfo['extension']) ? strtolower($pathInfo['extension']) : null;
+        if ($extension !== null && array_key_exists($extension, $this->excludedExtensions) && $this->excludedExtensions[$extension] === true) {
             throw new TargetException(sprintf('Could not publish "%s" into resource publishing target "%s" because the filename extension "%s" is excluded.', $sourceStream, $this->name, strtolower($pathInfo['extension'])), 1447152230);
         }