Neos 9 Support #133
Merged
Neos 9 Support #133
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…collection. fix usage of nodeType.name.
bwaidelich
requested changes
Apr 16, 2024
There was a problem hiding this comment.
Wow, impressive, thanks for biting through this!
I'll block this for now, since 9.0 is not available yet and because the work around for the missing signals is not implemented yet – I'm currently working on a simpler hooking mechanism with neos/neos-development-collection#4992 – with that in place, we can probably easily re-implement the "unique form element identifier" mechanism.
I also added some more inline comments
…ationHandlerInterface` in neos/neos-ui#3519
… creation of select options.
bwaidelich
reviewed
Aug 19, 2024
bwaidelich
approved these changes
Oct 28, 2024
|
Hi @samsauter Thanks for taking care. This helps a lot. Could you please also address the open questions of @bwaidelich? |
dlubitz
reviewed
Oct 31, 2024
dlubitz
reviewed
Oct 31, 2024
|
@samsauter I've created a PR against your branch with some more changes. |
Neos 9 Support
…ASK: Upgrade identifier and editMode to Neos 9.0 https://github.com/Format-D/form-builder/pull/1/commits
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding Neos 9 compatibilty.
Classes/Package.php, because there are noNodesignal slots anymore. How would we go about that in the future? Do we need to use an Anspect now?