Skip to content

Commit

Permalink
TASK: Remove b/c layer CommandResult::block()
Browse files Browse the repository at this point in the history
  • Loading branch information
mhsdesign committed Jul 3, 2024
1 parent 0f92081 commit 157ebc6
Show file tree
Hide file tree
Showing 2 changed files with 5 additions and 13 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -12,16 +12,12 @@
*
* This will no longer be required in the future see https://github.com/neos/neos-development-collection/pull/4988
*
* @deprecated this b/c layer will be removed with the next beta or before Neos 9 final release
* @api
* TODO decide whether it might be useful to have some return type that tells something about the published events
* (e.g. last sequence number) and maybe even about the updated/skipped projections
* see discussion: https://github.com/neos/neos-development-collection/pull/5061#issuecomment-2117643465
*
* @internal this object will either be transformed into something useful and made API or deleted.
*/
final readonly class CommandResult
{
/**
* We block by default thus you must not call this method or use this legacy stub
* @deprecated this b/c layer will be removed with the next beta or before Neos 9 final release
*/
public function block(): void
{
}
}
4 changes: 0 additions & 4 deletions Neos.ContentRepository.Core/Classes/ContentRepository.php
Original file line number Diff line number Diff line change
Expand Up @@ -90,10 +90,6 @@ public function __construct(
/**
* The only API to send commands (mutation intentions) to the system.
*
* The system is ASYNCHRONOUS by default, so that means the projection is not directly up to date. If you
* need to be synchronous, call {@see CommandResult::block()} on the returned CommandResult - then the system
* waits until the projections are up to date.
*
* @param CommandInterface $command
* @return CommandResult
*/
Expand Down

0 comments on commit 157ebc6

Please sign in to comment.