TASK: Remove obsolete special handling for DateTimeInterface

With #4251 `NodeType::getDefaultValuesForProperties` doesnt return a `DateTime` anymore for dateTime default values
neos · Mar 1, 2024 · 41bc886 · 41bc886
1 parent 26ce195
commit 41bc886
Show file tree

Hide file tree

Showing 3 changed files with 1 addition and 12 deletions.
diff --git a/....ContentRepository.Core/Classes/Feature/NodeModification/Dto/SerializedPropertyValues.php b/....ContentRepository.Core/Classes/Feature/NodeModification/Dto/SerializedPropertyValues.php
@@ -72,10 +72,6 @@ public static function defaultFromNodeType(NodeType $nodeType, PropertyConverter
     {
         $values = [];
         foreach ($nodeType->getDefaultValuesForProperties() as $propertyName => $defaultValue) {
-            if ($defaultValue instanceof \DateTimeInterface) {
-                $defaultValue = json_encode($defaultValue);
-            }
-
             $propertyType = PropertyType::fromNodeTypeDeclaration(
                 $nodeType->getPropertyType($propertyName),
                 PropertyName::fromString($propertyName),

diff --git a/Neos.ContentRepository.Core/Classes/NodeType/NodeType.php b/Neos.ContentRepository.Core/Classes/NodeType/NodeType.php
@@ -433,7 +433,7 @@ public function getPropertyType(string $propertyName): string
      *
      * The default value is configured for each property under the "default" key.
      *
-     * @return array<string,mixed>
+     * @return array<string,int|float|string|bool|array<int|string,mixed>>
      * @api
      */
     public function getDefaultValuesForProperties(): array

diff --git a/Neos.ContentRepository.StructureAdjustment/src/Adjustment/PropertyAdjustment.php b/Neos.ContentRepository.StructureAdjustment/src/Adjustment/PropertyAdjustment.php
@@ -78,13 +78,6 @@ public function findAdjustmentsForNodeType(NodeTypeName $nodeTypeName): \Generat
 
                 // detect missing default values
                 foreach ($nodeType->getDefaultValuesForProperties() as $propertyKey => $defaultValue) {
-                    if ($defaultValue instanceof \DateTimeInterface) {
-                        $defaultValue = json_encode($defaultValue);
-                    }
-                    if ($defaultValue === null) {
-                        // we don't need to set null as default value if it doesn't exist
-                        continue;
-                    }
                     if (!array_key_exists($propertyKey, $propertyKeysInNode)) {
                         yield StructureAdjustment::createForNode(
                             $node,