TASK: Add and enforce strict_type declarations

Adds a

```
declare(strict_types=1);
```

declaration to all PHP files of the core that were missing one and implements & defines a new PHPStan rule to enforce them from now on

Related: #5239

Neos.ContentGraph.DoctrineDbalAdapter/src/ContentGraphFactory.php

@@ -1,5 +1,7 @@
 <?php
 
+declare(strict_types=1);
+
 /*
  * This file is part of the Neos.ContentGraph.DoctrineDbalAdapter package.
  *

Neos.ContentGraph.DoctrineDbalAdapter/src/ContentGraphTableNames.php

@@ -1,5 +1,7 @@
 <?php
 
+declare(strict_types=1);
+
 namespace Neos\ContentGraph\DoctrineDbalAdapter;
 
 use Neos\ContentRepository\Core\SharedModel\ContentRepository\ContentRepositoryId;

Neos.ContentGraph.DoctrineDbalAdapter/src/DoctrineDbalContentGraphSchemaBuilder.php

@@ -1,5 +1,7 @@
 <?php
 
+declare(strict_types=1);
+
 namespace Neos\ContentGraph\DoctrineDbalAdapter;
 
 use Doctrine\DBAL\Exception as DBALException;

Neos.ContentGraph.DoctrineDbalAdapter/src/DoctrineDbalProjectionIntegrityViolationDetectionRunnerFactory.php

@@ -1,5 +1,7 @@
 <?php
 
+declare(strict_types=1);
+
 namespace Neos\ContentGraph\DoctrineDbalAdapter;
 
 use Doctrine\DBAL\Connection;

Neos.ContentGraph.DoctrineDbalAdapter/src/NodeQueryBuilder.php

@@ -1,5 +1,7 @@
 <?php
 
+declare(strict_types=1);
+
 namespace Neos\ContentGraph\DoctrineDbalAdapter;
 
 use Doctrine\DBAL\ArrayParameterType;

Neos.ContentGraph.PostgreSQLAdapter/src/ContentHyperGraphFactory.php

@@ -1,5 +1,7 @@
 <?php
 
+declare(strict_types=1);
+
 namespace Neos\ContentGraph\PostgreSQLAdapter;
 
 use Doctrine\DBAL\Connection;

Neos.ContentGraph.PostgreSQLAdapter/src/Domain/Projection/SchemaBuilder/HypergraphSchemaBuilder.php

@@ -1,5 +1,7 @@
 <?php
 
+declare(strict_types=1);
+
 namespace Neos\ContentGraph\PostgreSQLAdapter\Domain\Projection\SchemaBuilder;
 
 use Doctrine\DBAL\Platforms\AbstractPlatform;

Neos.ContentGraph.PostgreSQLAdapter/src/Domain/Projection/SchemaBuilder/JsonbType.php

@@ -1,5 +1,7 @@
 <?php
 
+declare(strict_types=1);
+
 namespace Neos\ContentGraph\PostgreSQLAdapter\Domain\Projection\SchemaBuilder;
 
 use Doctrine\DBAL\Platforms\AbstractPlatform;

Neos.ContentGraph.PostgreSQLAdapter/src/Domain/Projection/SchemaBuilder/UuidArrayType.php

@@ -1,5 +1,7 @@
 <?php
 
+declare(strict_types=1);
+
 namespace Neos\ContentGraph\PostgreSQLAdapter\Domain\Projection\SchemaBuilder;
 
 use Doctrine\DBAL\Platforms\AbstractPlatform;

Neos.ContentGraph.PostgreSQLAdapter/src/Domain/Projection/SchemaBuilder/UuidType.php

@@ -1,5 +1,7 @@
 <?php
 
+declare(strict_types=1);
+
 namespace Neos\ContentGraph\PostgreSQLAdapter\Domain\Projection\SchemaBuilder;
 
 use Doctrine\DBAL\Platforms\AbstractPlatform;

Neos.ContentGraph.PostgreSQLAdapter/src/Domain/Projection/SchemaBuilder/VarcharArrayType.php

@@ -1,5 +1,7 @@
 <?php
 
+declare(strict_types=1);
+
 namespace Neos\ContentGraph\PostgreSQLAdapter\Domain\Projection\SchemaBuilder;
 
 use Doctrine\DBAL\Platforms\AbstractPlatform;

Neos.ContentRepository.BehavioralTests/Classes/PhpstanRules/DeclareStrictTypesRule.php

@@ -0,0 +1,47 @@
+<?php
+
+declare(strict_types=1);
+
+namespace Neos\ContentRepository\BehavioralTests\PhpstanRules;
+
+use PhpParser\Node;
+use PHPStan\Analyser\Scope;
+use PHPStan\Node\FileNode;
+use PHPStan\Rules\Rule;
+
+/**
+ * @implements Rule<FileNode>
+ */
+class DeclareStrictTypesRule implements Rule
+{
+    public function getNodeType(): string
+    {
+        return FileNode::class;
+    }
+
+    public function processNode(Node $node, Scope $scope): array
+    {
+        assert($node instanceof FileNode);
+        $nodes = $node->getNodes();
+        if (0 === \count($nodes)) {
+            return [];
+        }
+        $firstNode = \array_shift($nodes);
+
+        if ($firstNode instanceof Node\Stmt\Declare_) {
+            foreach ($firstNode->declares as $declare) {
+                if (
+                    $declare->value instanceof Node\Scalar\LNumber
+                    && $declare->key->toLowerString() === 'strict_types'
+                    && $declare->value->value === 1
+                ) {
+                    return [];
+                }
+            }
+        }
+
+        return [
+            'File is missing a "declare(strict_types=1)" declaration.',
+        ];
+    }
+}

Neos.ContentRepository.Core/Classes/Factory/ContentRepositoryServiceFactoryInterface.php

@@ -1,5 +1,7 @@
 <?php
 
+declare(strict_types=1);
+
 namespace Neos\ContentRepository\Core\Factory;
 
 /**

Neos.ContentRepository.Core/Classes/Factory/ContentRepositoryServiceInterface.php

@@ -1,5 +1,7 @@
 <?php
 
+declare(strict_types=1);
+
 namespace Neos\ContentRepository\Core\Factory;
 
 use Neos\ContentRepository\Core\ContentRepository;

Neos.ContentRepository.Core/Classes/Factory/ProjectionsAndCatchUpHooksFactory.php

@@ -1,5 +1,7 @@
 <?php
 
+declare(strict_types=1);
+
 namespace Neos\ContentRepository\Core\Factory;
 
 use Neos\ContentRepository\Core\Projection\CatchUpHookFactories;

Neos.ContentRepository.Core/Classes/Feature/NodeDuplication/Dto/NodeAggregateIdMapping.php

@@ -1,5 +1,7 @@
 <?php
 
+declare(strict_types=1);
+
 namespace Neos\ContentRepository\Core\Feature\NodeDuplication\Dto;
 
 /*

Neos.ContentRepository.Core/Classes/NodeType/ConstraintCheck.php

@@ -1,5 +1,7 @@
 <?php
 
+declare(strict_types=1);
+
 namespace Neos\ContentRepository\Core\NodeType;
 
 /**

Neos.ContentRepository.Core/Classes/Projection/CatchUpHookInterface.php

@@ -1,9 +1,10 @@
 <?php
 
+declare(strict_types=1);
+
 namespace Neos\ContentRepository\Core\Projection;
 
 use Neos\ContentRepository\Core\EventStore\EventInterface;
-use Neos\EventStore\CatchUp\CheckpointStorageInterface;
 use Neos\EventStore\Model\EventEnvelope;
 
 /**

Neos.ContentRepository.Core/Classes/Projection/CheckpointStorageStatus.php

@@ -1,5 +1,7 @@
 <?php
 
+declare(strict_types=1);
+
 namespace Neos\ContentRepository\Core\Projection;
 
 /**

Neos.ContentRepository.Core/Classes/Projection/DelegatingCatchUpHook.php

@@ -1,5 +1,7 @@
 <?php
 
+declare(strict_types=1);
+
 namespace Neos\ContentRepository\Core\Projection;
 
 use Neos\ContentRepository\Core\EventStore\EventInterface;

Neos.ContentRepository.Core/Classes/Projection/ProjectionStatus.php

@@ -1,5 +1,7 @@
 <?php
 
+declare(strict_types=1);
+
 namespace Neos\ContentRepository\Core\Projection;
 
 /**

Neos.ContentRepository.Core/Classes/Projection/ProjectionStatusType.php

@@ -1,5 +1,7 @@
 <?php
 
+declare(strict_types=1);
+
 namespace Neos\ContentRepository\Core\Projection;
 
 /**

Neos.ContentRepository.Core/Classes/Projection/ProjectionStatuses.php

@@ -1,5 +1,7 @@
 <?php
 
+declare(strict_types=1);
+
 namespace Neos\ContentRepository\Core\Projection;
 
 /**

Neos.ContentRepository.Core/Classes/Projection/Workspace/WorkspaceStatus.php

@@ -1,5 +1,7 @@
 <?php
 
+declare(strict_types=1);
+
 namespace Neos\ContentRepository\Core\Projection\Workspace;
 
 /**

Neos.ContentRepository.Core/Classes/SharedModel/Exception/NodeAggregateCurrentlyDoesNotExist.php

@@ -1,5 +1,7 @@
 <?php
 
+declare(strict_types=1);
+
 namespace Neos\ContentRepository\Core\SharedModel\Exception;
 
 /*

Neos.ContentRepository.Core/Classes/SharedModel/Exception/NodeAggregateCurrentlyExists.php

@@ -1,5 +1,7 @@
 <?php
 
+declare(strict_types=1);
+
 namespace Neos\ContentRepository\Core\SharedModel\Exception;
 
 /*

Neos.ContentRepository.Core/Classes/SharedModel/Exception/NodeAggregateIsAmbiguous.php

@@ -1,5 +1,7 @@
 <?php
 
+declare(strict_types=1);
+
 namespace Neos\ContentRepository\Core\SharedModel\Exception;
 
 /*

Neos.ContentRepository.Core/Classes/SharedModel/Exception/NodeAggregateIsDescendant.php

@@ -1,5 +1,7 @@
 <?php
 
+declare(strict_types=1);
+
 namespace Neos\ContentRepository\Core\SharedModel\Exception;
 
 /*

Neos.ContentRepository.Core/Classes/SharedModel/Exception/NodeAggregateIsNotRoot.php

@@ -1,5 +1,7 @@
 <?php
 
+declare(strict_types=1);
+
 namespace Neos\ContentRepository\Core\SharedModel\Exception;
 
 /*

Neos.ContentRepository.Core/Classes/SharedModel/Exception/NodeAggregateIsRoot.php

@@ -1,5 +1,7 @@
 <?php
 
+declare(strict_types=1);
+
 namespace Neos\ContentRepository\Core\SharedModel\Exception;
 
 /*

Neos.ContentRepository.Core/Classes/SharedModel/Exception/NodeAggregateIsTethered.php

@@ -1,5 +1,7 @@
 <?php
 
+declare(strict_types=1);
+
 namespace Neos\ContentRepository\Core\SharedModel\Exception;
 
 /*

Neos.ContentRepository.Core/Classes/SharedModel/Exception/NodeNameIsAlreadyCovered.php

@@ -1,5 +1,7 @@
 <?php
 
+declare(strict_types=1);
+
 namespace Neos\ContentRepository\Core\SharedModel\Exception;
 
 /*

Neos.ContentRepository.Core/Classes/SharedModel/Exception/NodeTypeIsAbstract.php

@@ -1,5 +1,7 @@
 <?php
 
+declare(strict_types=1);
+
 namespace Neos\ContentRepository\Core\SharedModel\Exception;
 
 /*

Neos.ContentRepository.Core/Classes/SharedModel/Exception/NodeTypeIsNotOfTypeRoot.php

@@ -1,5 +1,7 @@
 <?php
 
+declare(strict_types=1);
+
 namespace Neos\ContentRepository\Core\SharedModel\Exception;
 
 /*

Neos.ContentRepository.Core/Classes/SharedModel/Exception/NodeTypeIsOfTypeRoot.php

@@ -1,5 +1,7 @@
 <?php
 
+declare(strict_types=1);
+
 namespace Neos\ContentRepository\Core\SharedModel\Exception;
 
 /*

Neos.ContentRepository.Export/src/Exception/LiveWorkspaceContentStreamExistsException.php

@@ -1,5 +1,7 @@
 <?php
 
+declare(strict_types=1);
+
 namespace Neos\ContentRepository\Export\Exception;
 
 use Neos\Flow\Annotations as Flow;

Neos.ContentRepository.NodeAccess/Classes/FlowQueryOperations/BackReferenceNodesOperation.php

@@ -1,4 +1,7 @@
 <?php
+
+declare(strict_types=1);
+
 namespace Neos\ContentRepository\NodeAccess\FlowQueryOperations;
 
 /*

Neos.ContentRepository.NodeAccess/Classes/FlowQueryOperations/BackReferencesOperation.php

@@ -1,4 +1,7 @@
 <?php
+
+declare(strict_types=1);
+
 namespace Neos\ContentRepository\NodeAccess\FlowQueryOperations;
 
 /*

Neos.ContentRepository.NodeAccess/Classes/FlowQueryOperations/ChildrenOperation.php

@@ -1,4 +1,7 @@
 <?php
+
+declare(strict_types=1);
+
 namespace Neos\ContentRepository\NodeAccess\FlowQueryOperations;
 
 /*

Neos.ContentRepository.NodeAccess/Classes/FlowQueryOperations/ClosestOperation.php

@@ -1,4 +1,7 @@
 <?php
+
+declare(strict_types=1);
+
 namespace Neos\ContentRepository\NodeAccess\FlowQueryOperations;
 
 /*

Neos.ContentRepository.NodeAccess/Classes/FlowQueryOperations/FilterOperation.php

@@ -1,4 +1,7 @@
 <?php
+
+declare(strict_types=1);
+
 namespace Neos\ContentRepository\NodeAccess\FlowQueryOperations;
 
 /*

Neos.ContentRepository.NodeAccess/Classes/FlowQueryOperations/FindOperation.php

@@ -1,4 +1,7 @@
 <?php
+
+declare(strict_types=1);
+
 namespace Neos\ContentRepository\NodeAccess\FlowQueryOperations;
 
 /*

Neos.ContentRepository.NodeAccess/Classes/FlowQueryOperations/HasOperation.php

@@ -1,4 +1,7 @@
 <?php
+
+declare(strict_types=1);
+
 namespace Neos\ContentRepository\NodeAccess\FlowQueryOperations;
 
 /*

Neos.ContentRepository.NodeAccess/Classes/FlowQueryOperations/IdOperation.php

@@ -1,4 +1,7 @@
 <?php
+
+declare(strict_types=1);
+
 namespace Neos\ContentRepository\NodeAccess\FlowQueryOperations;
 
 /*