WIP: Fix phpstan

neos · Jun 23, 2024 · 742b123 · 742b123
1 parent 694b621
commit 742b123
Show file tree

Hide file tree

Showing 3 changed files with 5 additions and 2 deletions.
diff --git a/...ioralTests/Classes/PhpstanRules/InternalMethodsNotAllowedOutsideContentRepositoryRule.php b/...ioralTests/Classes/PhpstanRules/InternalMethodsNotAllowedOutsideContentRepositoryRule.php
@@ -74,7 +74,7 @@ public function processNode(Node $node, Scope $scope): array
                                 $targetClassName,
                                 $node->name->toString()
                             )
-                        )->build(),
+                        )->identifier('neos.internal')->build(),
                     ];
                 }
             }

diff --git a/Neos.ContentRepositoryRegistry/Classes/Command/CrCommandController.php b/Neos.ContentRepositoryRegistry/Classes/Command/CrCommandController.php
@@ -280,7 +280,7 @@ public function listCommand(bool $verbose = false): void
 
             $liveContentGraph = null;
             try {
-                $liveContentGraph = $contentRepository->getContentGraph(WorkspaceName::forLive());
+                $liveContentGraph = $contentRepository?->getContentGraph(WorkspaceName::forLive());
             } catch (WorkspaceDoesNotExist) {
                 $this->outputLine('<comment>Live workspace in content repository %s not existing.</comment>', [$contentRepositoryId->value]);
             }
@@ -298,6 +298,7 @@ public function listCommand(bool $verbose = false): void
                 if ($sitesAggregate) {
                     $siteNodeAggregates = $liveContentGraph->findChildNodeAggregates($sitesAggregate->nodeAggregateId);
                     foreach ($siteNodeAggregates as $siteNodeAggregate) {
+                        assert($siteNodeAggregate->nodeName !== null);
                         $currenSiteNodes[] = $siteNodeAggregate->nodeName->value;
                     }
                 }
@@ -340,6 +341,7 @@ public function listCommand(bool $verbose = false): void
 
                 if ($verbose) {
                     try {
+                        /** @phpstan-ignore neos.internal */
                         $contentStreamsString = sprintf('%d found', iterator_count($contentRepository->getContentStreamFinder()->findAllIds()));
                     } catch (\RuntimeException $e) {
                         $this->outputLine('<comment>ContentStreamFinder of %s not functional: %s.</comment>', [$contentRepositoryId->value, $e->getMessage()]);

diff --git a/Neos.ContentRepositoryRegistry/Classes/ContentRepositoryRegistry.php b/Neos.ContentRepositoryRegistry/Classes/ContentRepositoryRegistry.php
@@ -86,6 +86,7 @@ public function get(ContentRepositoryId $contentRepositoryId): ContentRepository
      */
     public function getContentRepositoryIds(): iterable
     {
+        /** @phpstan-ignore argument.type */
         return array_map(ContentRepositoryId::fromString(...), array_keys($this->settings['contentRepositories'] ?? []));
     }
-Original file line number
+Diff line change
@@ Expand Up @@
          */
         public function getContentRepositoryIds(): iterable
         {
+            /** @phpstan-ignore argument.type */
             return array_map(ContentRepositoryId::fromString(...), array_keys($this->settings['contentRepositories'] ?? []));
         }
@@ Expand Down @@