-
-
Notifications
You must be signed in to change notification settings - Fork 224
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
TASK: Add changelog for 8.3.19 [skip ci]
- Loading branch information
Jenkins
committed
Jan 21, 2025
1 parent
0a60c57
commit ccf3944
Showing
1 changed file
with
129 additions
and
0 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,129 @@ | ||
`8.3.19 (2025-01-21) <https://github.com/neos/neos-development-collection/releases/tag/8.3.19>`_ | ||
================================================================================================ | ||
|
||
Overview of merged pull requests | ||
~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ | ||
|
||
`BUGFIX: Add missing event emitters to internal node properties <https://github.com/neos/neos-development-collection/pull/5343>`_ | ||
--------------------------------------------------------------------------------------------------------------------------------- | ||
|
||
**Review instructions** | ||
|
||
Currently, when using the event log, internal node data is not logged. So whenever an internal property like ``_hiddenBeforeDateTime`` is changed, you can't see that property in the event log. Therefore, this PR adds missing event emitters to the methods used to set the internal properties. | ||
|
||
resolved: `#3284 <https://github.com/neos/neos-development-collection/issues/3284>`_ | ||
|
||
|
||
* Packages: ``Neos`` ``ContentRepository`` | ||
|
||
`BUGFIX: Force direct access on setting node properties in node data similarize <https://github.com/neos/neos-development-collection/pull/5281>`_ | ||
------------------------------------------------------------------------------------------------------------------------------------------------- | ||
|
||
The ``creationDateTime`` has no setters in AbstractNodeData, so the NodeData::similarize can't set them in the target node propery. We need to allow the ``ObjectAccess::setProperty`` to force direct access to the class properties. | ||
|
||
The ``lastModificationDateTime`` was also not copied before this bugfix and shouldn't be copied anyways. | ||
|
||
* Fixes: `#5280 <https://github.com/neos/neos-development-collection/issues/5280>`_ | ||
|
||
* Packages: ``ContentRepository`` | ||
|
||
`BUGFIX: Fixed table view of asset editor <https://github.com/neos/neos-development-collection/pull/5432>`_ | ||
----------------------------------------------------------------------------------------------------------- | ||
|
||
Related to https://github.com/neos/neos-development-collection/issues/5430 | ||
|
||
This table view: | ||
|
||
<img width="1594" alt="image" src="https://github.com/user-attachments/assets/3ff81f3e-477a-42fe-ad77-3074fa0d14ae" /> | ||
|
||
doesn't currently work because the event listener checks whether there is an <a> or a <button> but doesn't check for <tr>. I fixed it by removing the check completely and using e.currentTarget instead of e.target. | ||
|
||
The check was not necessary because the eventlistener was already only added to the elements that meet the criteria. | ||
The use of event.currentTarget ensures that you always use the element that the eventlistener was actually added to, whereas event.target is the element that was clicked, which is not necessary in this case. | ||
|
||
Nothing has to be adjusted to use this. | ||
|
||
* Packages: ``Media.Browser`` | ||
|
||
`BUGFIX: Share same role details when adding user as when editing them <https://github.com/neos/neos-development-collection/pull/5206>`_ | ||
---------------------------------------------------------------------------------------------------------------------------------------- | ||
|
||
When editing users, much more information was shown about the individual roles than when adding a user, where whoever adds them gets no information about the role except its name. | ||
|
||
With this change the descriptions of the role and their individual privileges are displayed in the same way as in the edit account view. | ||
|
||
**Review instructions** | ||
|
||
Before: | ||
|
||
<img src="https://github.com/user-attachments/assets/744c1f60-3927-4178-810e-1e0635af9dcc" width="500" /> | ||
|
||
After: | ||
|
||
<img src="https://github.com/user-attachments/assets/b725bf47-925e-474b-890b-0e06eae410a3" width="500" /> | ||
|
||
|
||
Current edit account view: | ||
|
||
<img src="https://github.com/user-attachments/assets/603889c7-38af-4d6f-92b0-e3e1640a1f5e" width="500" /> | ||
|
||
|
||
* Packages: ``Neos`` | ||
|
||
`BUGFIX: Correct node naming scheme in nodetype definition example <https://github.com/neos/neos-development-collection/pull/5426>`_ | ||
------------------------------------------------------------------------------------------------------------------------------------ | ||
|
||
The example uses an outdated camelcase variant for node names. | ||
|
||
Relates: https://github.com/Sebobo/Shel.Neos.Schema/issues/26 | ||
|
||
* Packages: ``Neos`` | ||
|
||
`TASK: Render command references <https://github.com/neos/neos-development-collection/pull/5443>`_ | ||
--------------------------------------------------------------------------------------------------- | ||
|
||
also for Neos.ContentRepository.Migration, Neos.Neos.Setup and Neos.Setup | ||
|
||
They were simply missing in the list of command identifier which are allowed to render the command reference. | ||
|
||
See: https://github.com/neos/neos-development-collection/pull/4177#issuecomment-2598509517 | ||
|
||
* Packages: ``Neos`` | ||
|
||
`TASK: Fix MySQL migration differences on fresh setup <https://github.com/neos/neos-development-collection/pull/4236>`_ | ||
----------------------------------------------------------------------------------------------------------------------- | ||
|
||
This eliminates some differences in the actual vs the expected DB setup in a fresh | ||
Neos 8.3 installation. | ||
|
||
* Fixes: `#3118 <https://github.com/neos/neos-development-collection/issues/3118>`_ (at least partly.) | ||
|
||
**Review instructions** | ||
|
||
``doctrine:migrationgenerate`` should just say ``No changes detected`` after Neos has been set up. | ||
|
||
|
||
* Packages: ``Neos`` ``ContentRepository`` ``Media`` | ||
|
||
`TASK: Allow setting itemsPerPage in user administration listing <https://github.com/neos/neos-development-collection/pull/5325>`_ | ||
---------------------------------------------------------------------------------------------------------------------------------- | ||
|
||
With Neos 8.3, pagination was added to the user management module, but the number of users page page was not made configurable and set at a very low number of 10. This non-breaking change introduces this as a setting, keeping the default of 10. | ||
|
||
* Packages: ``ContentRepository`` ``Neos`` | ||
|
||
`TASK: Make nullable parameter explicit to become PHP 8.4 compatible <https://github.com/neos/neos-development-collection/pull/5433>`_ | ||
-------------------------------------------------------------------------------------------------------------------------------------- | ||
|
||
I've used rector to migrate all occurrences. | ||
|
||
https://getrector.com/rule-detail/explicit-nullable-param-type-rector | ||
|
||
See also for Flow: https://github.com/neos/flow-development-collection/pull/3429 | ||
|
||
Note: We should run the rector migration again on 9.0 after upmerging this PR | ||
|
||
* Packages: ``.github`` | ||
|
||
`Detailed log <https://github.com/neos/neos-development-collection/compare/8.3.18...8.3.19>`_ | ||
~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ |